mirror of
				https://github.com/MariaDB/server.git
				synced 2025-11-03 14:33:32 +03:00 
			
		
		
		
	Post-review fixes. Mostly whitespace, int-to-bool return value, fixed comments
sql/Makefile.am:
  compile all submodules of Events before compiling the facade
sql/event_data_objects.cc:
  - Use initialization list
  - Clean whitespaces
  - Shorten comments
  - Fix comments
sql/event_data_objects.h:
  - Fix whitespace
sql/event_db_repository.cc:
  - Change return type from int to bool where only one error code is
    returned.
  - Don't use macros but get the maximal number of characters in a column
    from the column
  - Fix  comments
  - Make functions which has return value but it's not used - void.
sql/event_db_repository.h:
  - Methods with only one error code int -> bool return value
  - Remove declaration of fill_schema_events, a function that does not exist
sql/event_queue.cc:
  - Use initialization lists
  - Let find_n_remove_event delete the object thus making the code more robust.
    The caller could forget to destruct the object. In addition, find_n_remove_element()
    does not return a value.
  - Move check_system_tables() to class Events
  - Fix comments
sql/event_queue.h:
  - Whitespace changes
  - init_queue() should allow passing of THD
  - check_system_tables moved to class Events
  - find_n_remove_event() is now void
sql/event_scheduler.cc:
  - Initialize res before use
  - Remove end stop from message
sql/event_scheduler.h:
  Add uninitialized state. The scheduler is in it before init_scheduler()
  is called. The rationale is that otherwise state has no value before
  the call. If the system tables were damaged the scheduler won't be initialized
  but in Events::deinit() Event_scheduler::stop() will be called and this will
  touch state, generating valgrind warning at minimum.
sql/events.cc:
  - Whitespace changes
  - Fix comments
  - Make methods which have only one error code be bool instead of int
  - Create temporarily a THD to be used for the initialization of Event_queue
  - Event_queue::check_system_tables() moved to Events::check_system_tables
  - is_started() is renamed to is_execution_of_events_started()
sql/events.h:
  - Whitespace changes
  - When a method returns only one error code it should be bool, not int
  - is_started() renamed to is_execution_of_events_started()
sql/set_var.cc:
  is_started() is renamed to is_execution_of_events_started()
sql/sql_db.cc:
  The return code is not used, thus don't return anything and drop_schema_events()
  is now void.
sql/sql_yacc.yy:
  - Fix comments
  - Remove unneeded initialization which is performed in lex_init()
sql/share/errmsg.txt:
  New error message
sql/table.cc:
  - Fix comments
  - make table_check_intact() accespt const *table_def
sql/table.h:
  Make table_check_intact() accespt const *table_def
		
	
		
			
				
	
	
		
			286 lines
		
	
	
		
			5.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			286 lines
		
	
	
		
			5.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
#ifndef _EVENT_DATA_OBJECTS_H_
 | 
						|
#define _EVENT_DATA_OBJECTS_H_
 | 
						|
/* Copyright (C) 2004-2006 MySQL AB
 | 
						|
 | 
						|
   This program is free software; you can redistribute it and/or modify
 | 
						|
   it under the terms of the GNU General Public License as published by
 | 
						|
   the Free Software Foundation; either version 2 of the License, or
 | 
						|
   (at your option) any later version.
 | 
						|
 | 
						|
   This program is distributed in the hope that it will be useful,
 | 
						|
   but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
						|
   GNU General Public License for more details.
 | 
						|
 | 
						|
   You should have received a copy of the GNU General Public License
 | 
						|
   along with this program; if not, write to the Free Software
 | 
						|
   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA */
 | 
						|
 | 
						|
 | 
						|
#define EVEX_GET_FIELD_FAILED   -2
 | 
						|
#define EVEX_COMPILE_ERROR      -3
 | 
						|
#define EVEX_GENERAL_ERROR      -4
 | 
						|
#define EVEX_BAD_PARAMS         -5
 | 
						|
#define EVEX_MICROSECOND_UNSUP  -6
 | 
						|
 | 
						|
 | 
						|
class sp_head;
 | 
						|
class Sql_alloc;
 | 
						|
 | 
						|
 | 
						|
class Event_basic
 | 
						|
{
 | 
						|
protected:
 | 
						|
  MEM_ROOT mem_root;
 | 
						|
 | 
						|
public:
 | 
						|
  LEX_STRING dbname;
 | 
						|
  LEX_STRING name;
 | 
						|
  LEX_STRING definer;// combination of user and host
 | 
						|
 | 
						|
  Event_basic();
 | 
						|
  virtual ~Event_basic();
 | 
						|
 | 
						|
  virtual int
 | 
						|
  load_from_row(TABLE *table) = 0;
 | 
						|
 | 
						|
protected:
 | 
						|
  bool
 | 
						|
  load_string_fields(Field **fields, ...);
 | 
						|
};
 | 
						|
 | 
						|
 | 
						|
 | 
						|
class Event_queue_element : public Event_basic
 | 
						|
{
 | 
						|
protected:
 | 
						|
  bool status_changed;
 | 
						|
  bool last_executed_changed;
 | 
						|
 | 
						|
public:
 | 
						|
  enum enum_status
 | 
						|
  {
 | 
						|
    ENABLED = 1,
 | 
						|
    DISABLED
 | 
						|
  };
 | 
						|
 | 
						|
  enum enum_on_completion
 | 
						|
  {
 | 
						|
    ON_COMPLETION_DROP = 1,
 | 
						|
    ON_COMPLETION_PRESERVE
 | 
						|
  };
 | 
						|
 | 
						|
  enum enum_on_completion on_completion;
 | 
						|
  enum enum_status status;
 | 
						|
  TIME last_executed;
 | 
						|
 | 
						|
  TIME execute_at;
 | 
						|
  TIME starts;
 | 
						|
  TIME ends;
 | 
						|
  my_bool starts_null;
 | 
						|
  my_bool ends_null;
 | 
						|
  my_bool execute_at_null;
 | 
						|
 | 
						|
  longlong expression;
 | 
						|
  interval_type interval;
 | 
						|
 | 
						|
  bool dropped;
 | 
						|
 | 
						|
  uint execution_count;
 | 
						|
 | 
						|
  Event_queue_element();
 | 
						|
  virtual ~Event_queue_element();
 | 
						|
 | 
						|
  virtual int
 | 
						|
  load_from_row(TABLE *table);
 | 
						|
 | 
						|
  bool
 | 
						|
  compute_next_execution_time();
 | 
						|
 | 
						|
  int
 | 
						|
  drop(THD *thd);
 | 
						|
 | 
						|
  void
 | 
						|
  mark_last_executed(THD *thd);
 | 
						|
 | 
						|
  bool
 | 
						|
  update_timing_fields(THD *thd);
 | 
						|
 | 
						|
  static void *operator new(size_t size)
 | 
						|
  {
 | 
						|
    void *p;
 | 
						|
    DBUG_ENTER("Event_queue_element::new(size)");
 | 
						|
    p= my_malloc(size, MYF(0));
 | 
						|
    DBUG_PRINT("info", ("alloc_ptr=0x%lx", p));
 | 
						|
    DBUG_RETURN(p);
 | 
						|
  }
 | 
						|
 | 
						|
  static void operator delete(void *ptr, size_t size)
 | 
						|
  {
 | 
						|
    DBUG_ENTER("Event_queue_element::delete(ptr,size)");
 | 
						|
    DBUG_PRINT("enter", ("free_ptr=0x%lx", ptr));
 | 
						|
    TRASH(ptr, size);
 | 
						|
    my_free((gptr) ptr, MYF(0));
 | 
						|
    DBUG_VOID_RETURN;
 | 
						|
  }
 | 
						|
};
 | 
						|
 | 
						|
 | 
						|
class Event_timed : public Event_queue_element
 | 
						|
{
 | 
						|
  Event_timed(const Event_timed &);	/* Prevent use of these */
 | 
						|
  void operator=(Event_timed &);
 | 
						|
 | 
						|
public:
 | 
						|
  LEX_STRING body;
 | 
						|
 | 
						|
  LEX_STRING definer_user;
 | 
						|
  LEX_STRING definer_host;
 | 
						|
 | 
						|
  LEX_STRING comment;
 | 
						|
 | 
						|
  ulonglong created;
 | 
						|
  ulonglong modified;
 | 
						|
 | 
						|
  ulong sql_mode;
 | 
						|
 | 
						|
  Event_timed();
 | 
						|
  virtual ~Event_timed();
 | 
						|
 | 
						|
  void
 | 
						|
  init();
 | 
						|
 | 
						|
  virtual int
 | 
						|
  load_from_row(TABLE *table);
 | 
						|
 | 
						|
  int
 | 
						|
  get_create_event(THD *thd, String *buf);
 | 
						|
};
 | 
						|
 | 
						|
 | 
						|
class Event_job_data : public Event_basic
 | 
						|
{
 | 
						|
public:
 | 
						|
  THD *thd;
 | 
						|
  sp_head *sphead;
 | 
						|
 | 
						|
  LEX_STRING body;
 | 
						|
  LEX_STRING definer_user;
 | 
						|
  LEX_STRING definer_host;
 | 
						|
 | 
						|
  ulong sql_mode;
 | 
						|
 | 
						|
  uint execution_count;
 | 
						|
 | 
						|
  Event_job_data();
 | 
						|
  virtual ~Event_job_data();
 | 
						|
 | 
						|
  virtual int
 | 
						|
  load_from_row(TABLE *table);
 | 
						|
 | 
						|
  int
 | 
						|
  execute(THD *thd);
 | 
						|
 | 
						|
  int
 | 
						|
  compile(THD *thd, MEM_ROOT *mem_root);
 | 
						|
private:
 | 
						|
  int
 | 
						|
  get_fake_create_event(THD *thd, String *buf);
 | 
						|
 | 
						|
  Event_job_data(const Event_job_data &);       /* Prevent use of these */
 | 
						|
  void operator=(Event_job_data &);
 | 
						|
};
 | 
						|
 | 
						|
 | 
						|
class Event_parse_data : public Sql_alloc
 | 
						|
{
 | 
						|
public:
 | 
						|
  enum enum_status
 | 
						|
  {
 | 
						|
    ENABLED = 1,
 | 
						|
    DISABLED
 | 
						|
  };
 | 
						|
 | 
						|
  enum enum_on_completion
 | 
						|
  {
 | 
						|
    ON_COMPLETION_DROP = 1,
 | 
						|
    ON_COMPLETION_PRESERVE
 | 
						|
  };
 | 
						|
  enum enum_on_completion on_completion;
 | 
						|
  enum enum_status status;
 | 
						|
 | 
						|
  const uchar *body_begin;
 | 
						|
 | 
						|
  LEX_STRING dbname;
 | 
						|
  LEX_STRING name;
 | 
						|
  LEX_STRING definer;// combination of user and host
 | 
						|
  LEX_STRING body;
 | 
						|
  LEX_STRING comment;
 | 
						|
 | 
						|
  Item* item_starts;
 | 
						|
  Item* item_ends;
 | 
						|
  Item* item_execute_at;
 | 
						|
 | 
						|
  TIME starts;
 | 
						|
  TIME ends;
 | 
						|
  TIME execute_at;
 | 
						|
  my_bool starts_null;
 | 
						|
  my_bool ends_null;
 | 
						|
  my_bool execute_at_null;
 | 
						|
 | 
						|
  sp_name *identifier;
 | 
						|
  Item* item_expression;
 | 
						|
  longlong expression;
 | 
						|
  interval_type interval;
 | 
						|
 | 
						|
  static Event_parse_data *
 | 
						|
  new_instance(THD *thd);
 | 
						|
 | 
						|
  bool
 | 
						|
  check_parse_data(THD *thd);
 | 
						|
 | 
						|
  void
 | 
						|
  init_body(THD *thd);
 | 
						|
 | 
						|
private:
 | 
						|
 | 
						|
  void
 | 
						|
  init_definer(THD *thd);
 | 
						|
 | 
						|
  void
 | 
						|
  init_name(THD *thd, sp_name *spn);
 | 
						|
 | 
						|
  int
 | 
						|
  init_execute_at(THD *thd);
 | 
						|
 | 
						|
  int
 | 
						|
  init_interval(THD *thd);
 | 
						|
 | 
						|
  int
 | 
						|
  init_starts(THD *thd);
 | 
						|
 | 
						|
  int
 | 
						|
  init_ends(THD *thd);
 | 
						|
 | 
						|
  Event_parse_data();
 | 
						|
  ~Event_parse_data();
 | 
						|
 | 
						|
  void
 | 
						|
  report_bad_value(const char *item_name, Item *bad_item);
 | 
						|
 | 
						|
  Event_parse_data(const Event_parse_data &);	/* Prevent use of these */
 | 
						|
  void operator=(Event_parse_data &);
 | 
						|
};
 | 
						|
 | 
						|
 | 
						|
/* Compares only the schema part of the identifier */
 | 
						|
bool
 | 
						|
event_basic_db_equal(LEX_STRING db, Event_basic *et);
 | 
						|
 | 
						|
/* Compares the whole identifier*/
 | 
						|
bool
 | 
						|
event_basic_identifier_equal(LEX_STRING db, LEX_STRING name, Event_basic *b);
 | 
						|
 | 
						|
 | 
						|
#endif /* _EVENT_DATA_OBJECTS_H_ */
 |