mirror of
https://github.com/MariaDB/server.git
synced 2025-05-01 08:45:04 +03:00
e7cf871dda
The warning out of OPTIMIZE Statement is unsafe because it uses a system function was indeed counterfactual and was resulted by checking an insufficiently strict property of lex' sql_command_flags. Fixed with deploying an additional checking of weather the current sql command that modifes a share->non_determinstic_insert table is capable of generating ROW format events. The extra check rules out the unsafety to OPTIMIZE et al, while the existing check continues to do so to CREATE TABLE (which is perculiarly tagged as ROW-event generative sql command). As a side effect sql_sequence.binlog test gets corrected and binlog_stm_unsafe_warning.test is reinforced to add up an unsafe CREATE..SELECT test.
39 lines
1.1 KiB
Plaintext
39 lines
1.1 KiB
Plaintext
--source include/have_sequence.inc
|
|
--source include/have_binlog_format_mixed_or_row.inc
|
|
--source include/binlog_start_pos.inc
|
|
|
|
#
|
|
# Testing binary logging of sequences
|
|
#
|
|
|
|
--disable_query_log
|
|
reset master; # get rid of previous tests binlog
|
|
--enable_query_log
|
|
|
|
create or replace sequence s1 cache 3;
|
|
select next value for s1, minimum_value from s1 where maximum_value> 1;
|
|
select next value for s1, minimum_value from s1 where maximum_value> 2;
|
|
select next value for s1, minimum_value from s1 where maximum_value> 3;
|
|
select next value for s1, minimum_value from s1 where maximum_value> 4;
|
|
|
|
#
|
|
# Alter sequence
|
|
#
|
|
alter sequence s1 maxvalue 1000;
|
|
|
|
# MDEV-24617 OPTIMIZE on a sequence causes unexpected
|
|
# ER_BINLOG_UNSAFE_STATEMENT The test below verifies no unsafe
|
|
# warnings anymore for any relavant commands that like OPTIMIZE can
|
|
# not produce ROW format events therefore the unsafe warning either.
|
|
optimize table s1;
|
|
analyze table s1;
|
|
repair table s1;
|
|
check table s1;
|
|
rename table s1 to tmp_s;
|
|
rename table tmp_s to s1;
|
|
|
|
drop sequence s1;
|
|
|
|
--let $binlog_file = LAST
|
|
source include/show_binlog_events.inc;
|