mirror of
https://github.com/MariaDB/server.git
synced 2025-05-25 13:42:52 +03:00
1656ea28e8
The fix of MDEV-13654 (commit ff81faf670e083e1da4f3e7bce33fe9104410b2c) wrongly caused ADD PRIMARY KEY to ignore duplicate PRIMARY KEY values caused by concurrent DML transactions that had been started before the ALTER TABLE operation (but did not access the table before the ALTER TABLE started). row_ins_duplicate_online(): Always report a duplicate key error if DB_TRX_ID had been reset (it belongs to a transaction that had started before the ALTER TABLE operation).
35 lines
813 B
Plaintext
35 lines
813 B
Plaintext
--source innodb_default_row_format.inc
|
|
--source include/have_debug.inc
|
|
--source include/have_debug_sync.inc
|
|
|
|
--echo #
|
|
--echo # MDEV-23244 ALTER TABLE…ADD PRIMARY KEY fails to flag
|
|
--echo # duplicate key error from concurrent DML
|
|
--echo #
|
|
|
|
CREATE TABLE t0 (pk INT PRIMARY KEY) ENGINE=InnoDB;
|
|
CREATE TABLE t1 (c CHAR(2) NOT NULL) ENGINE=InnoDB;
|
|
|
|
connect (con1,localhost,root,,);
|
|
BEGIN;
|
|
INSERT INTO t0 VALUES(1);
|
|
|
|
connection default;
|
|
SET DEBUG_SYNC='row_log_table_apply1_before SIGNAL dml WAIT_FOR dml_done';
|
|
send ALTER TABLE t1 ADD PRIMARY KEY(c(1));
|
|
|
|
connection con1;
|
|
SET DEBUG_SYNC='now WAIT_FOR dml';
|
|
INSERT INTO t1 VALUES ('ab'),('ac');
|
|
COMMIT;
|
|
SET DEBUG_SYNC='now SIGNAL dml_done';
|
|
disconnect con1;
|
|
|
|
connection default;
|
|
--error ER_DUP_ENTRY
|
|
reap;
|
|
SET DEBUG_SYNC='RESET';
|
|
|
|
SELECT * FROM t1;
|
|
DROP TABLE t0,t1;
|