mirror of
https://github.com/MariaDB/server.git
synced 2025-07-13 02:22:51 +03:00
c8ae357341
Lifted long standing limitation to the XA of rolling it back at the
transaction's
connection close even if the XA is prepared.
Prepared XA-transaction is made to sustain connection close or server
restart.
The patch consists of
- binary logging extension to write prepared XA part of
transaction signified with
its XID in a new XA_prepare_log_event. The concusion part -
with Commit or Rollback decision - is logged separately as
Query_log_event.
That is in the binlog the XA consists of two separate group of
events.
That makes the whole XA possibly interweaving in binlog with
other XA:s or regular transaction but with no harm to
replication and data consistency.
Gtid_log_event receives two more flags to identify which of the
two XA phases of the transaction it represents. With either flag
set also XID info is added to the event.
When binlog is ON on the server XID::formatID is
constrained to 4 bytes.
- engines are made aware of the server policy to keep up user
prepared XA:s so they (Innodb, rocksdb) don't roll them back
anymore at their disconnect methods.
- slave applier is refined to cope with two phase logged XA:s
including parallel modes of execution.
This patch does not address crash-safe logging of the new events which
is being addressed by MDEV-21469.
CORNER CASES: read-only, pure myisam, binlog-*, @@skip_log_bin, etc
Are addressed along the following policies.
1. The read-only at reconnect marks XID to fail for future
completion with ER_XA_RBROLLBACK.
2. binlog-* filtered XA when it changes engine data is regarded as
loggable even when nothing got cached for binlog. An empty
XA-prepare group is recorded. Consequent Commit-or-Rollback
succeeds in the Engine(s) as well as recorded into binlog.
3. The same applies to the non-transactional engine XA.
4. @@skip_log_bin=OFF does not record anything at XA-prepare
(obviously), but the completion event is recorded into binlog to
admit inconsistency with slave.
The following actions are taken by the patch.
At XA-prepare:
when empty binlog cache - don't do anything to binlog if RO,
otherwise write empty XA_prepare (assert(binlog-filter case)).
At Disconnect:
when Prepared && RO (=> no binlogging was done)
set Xid_cache_element::error := ER_XA_RBROLLBACK
*keep* XID in the cache, and rollback the transaction.
At XA-"complete":
Discover the error, if any don't binlog the "complete",
return the error to the user.
Kudos
-----
Alexey Botchkov took to drive this work initially.
Sergei Golubchik, Sergei Petrunja, Marko Mäkelä provided a number of
good recommendations.
Sergei Voitovich made a magnificent review and improvements to the code.
They all deserve a bunch of thanks for making this work done!
80 lines
2.2 KiB
Plaintext
80 lines
2.2 KiB
Plaintext
include/master-slave.inc
|
|
[connection master]
|
|
call mtr.add_suppression("Deadlock found");
|
|
call mtr.add_suppression("Can't find record in 't.'");
|
|
connection master;
|
|
CREATE TABLE t1 (a INT PRIMARY KEY, b INT) ENGINE=innodb;
|
|
INSERT INTO t1 VALUES (1,1), (2,2), (3,3), (4,4);
|
|
connection slave;
|
|
SHOW STATUS LIKE 'Slave_retried_transactions';
|
|
Variable_name Value
|
|
Slave_retried_transactions 0
|
|
set @@global.slave_exec_mode= 'IDEMPOTENT';
|
|
UPDATE t1 SET a = 5, b = 47 WHERE a = 1;
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a b
|
|
2 2
|
|
3 3
|
|
4 4
|
|
5 47
|
|
connection master;
|
|
UPDATE t1 SET a = 5, b = 5 WHERE a = 1;
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a b
|
|
2 2
|
|
3 3
|
|
4 4
|
|
5 5
|
|
connection slave;
|
|
set @@global.slave_exec_mode= default;
|
|
SHOW STATUS LIKE 'Slave_retried_transactions';
|
|
Variable_name Value
|
|
Slave_retried_transactions 0
|
|
SELECT * FROM t1 ORDER BY a;
|
|
a b
|
|
2 2
|
|
3 3
|
|
4 4
|
|
5 47
|
|
include/check_slave_is_running.inc
|
|
connection slave;
|
|
call mtr.add_suppression("Slave SQL.*Could not execute Update_rows event on table test.t1");
|
|
call mtr.add_suppression("Slave SQL for channel '': worker thread retried transaction");
|
|
call mtr.add_suppression("The slave coordinator and worker threads are stopped");
|
|
connection slave;
|
|
set @save_innodb_lock_wait_timeout=@@global.innodb_lock_wait_timeout;
|
|
set @save_slave_transaction_retries=@@global.slave_transaction_retries;
|
|
set @@global.innodb_lock_wait_timeout=1;
|
|
set @@global.slave_transaction_retries=2;
|
|
include/restart_slave.inc
|
|
connection slave1;
|
|
BEGIN;
|
|
INSERT INTO t1 SET a = 6, b = 7;
|
|
connection master;
|
|
INSERT INTO t1 SET a = 99, b = 99;
|
|
XA START 'xa1';
|
|
INSERT INTO t1 SET a = 6, b = 6;
|
|
XA END 'xa1';
|
|
XA PREPARE 'xa1';
|
|
connection slave;
|
|
include/wait_for_slave_sql_error.inc [errno=1213,1205]
|
|
set @@global.innodb_lock_wait_timeout=1;
|
|
set @@global.slave_transaction_retries=100;
|
|
include/restart_slave.inc
|
|
Warnings:
|
|
Note 1255 Slave already has been stopped
|
|
connection slave1;
|
|
ROLLBACK;
|
|
connection master;
|
|
XA COMMIT 'xa1';
|
|
include/sync_slave_sql_with_master.inc
|
|
connection slave;
|
|
include/assert.inc [XA transaction record must be in the table]
|
|
set @@global.innodb_lock_wait_timeout=@save_innodb_lock_wait_timeout;
|
|
set @@global.slave_transaction_retries= @save_slave_transaction_retries;
|
|
connection master;
|
|
DROP TABLE t1;
|
|
connection slave;
|
|
connection master;
|
|
include/rpl_end.inc
|