mirror of
https://github.com/MariaDB/server.git
synced 2025-08-01 03:47:19 +03:00
4cbfdeca84
MDEV-23855 broke the handling of innodb_flush_sync=OFF. That parameter is supposed to limit the page write rate in case the log capacity is being exceeded and log checkpoints are needed. With this fix, the following should pass: ./mtr --mysqld=--loose-innodb-flush-sync=0 One of our best regression tests for page flushing is encryption.innochecksum. With innodb_page_size=16k and innodb_flush_sync=OFF it would likely hang without this fix. log_sys.last_checkpoint_lsn: Declare as Atomic_relaxed<lsn_t> so that we are allowed to read the value while not holding log_sys.mutex. buf_flush_wait_flushed(): Let the page cleaner perform the flushing also if innodb_flush_sync=OFF. After the page cleaner has completed, perform a checkpoint if it is needed, because buf_flush_sync_for_checkpoint() will not be run if innodb_flush_sync=OFF. buf_flush_ahead(): Simplify the condition. We do not really care whether buf_flush_page_cleaner() is running. buf_flush_page_cleaner(): Evaluate innodb_flush_sync at the low level. If innodb_flush_sync=OFF, rate-limit the batches to innodb_io_capacity_max pages per second. Reviewed by: Vladislav Vaintroub
73 lines
2.5 KiB
Plaintext
73 lines
2.5 KiB
Plaintext
--source include/have_innodb.inc
|
|
|
|
SET @start_global_value = @@global.innodb_flush_sync;
|
|
|
|
#
|
|
# exists as global only
|
|
#
|
|
--echo Valid values are 'ON' and 'OFF'
|
|
select @@global.innodb_flush_sync in (0, 1);
|
|
--error ER_INCORRECT_GLOBAL_LOCAL_VAR
|
|
select @@session.innodb_flush_sync;
|
|
SET GLOBAL innodb_flush_sync = ON;
|
|
show global variables like 'innodb_flush_sync';
|
|
show session variables like 'innodb_flush_sync';
|
|
--disable_warnings
|
|
select * from information_schema.global_variables where variable_name='innodb_flush_sync';
|
|
select * from information_schema.session_variables where variable_name='innodb_flush_sync';
|
|
--enable_warnings
|
|
|
|
set global innodb_flush_sync='OFF';
|
|
select @@global.innodb_flush_sync;
|
|
--disable_warnings
|
|
select * from information_schema.global_variables where variable_name='innodb_flush_sync';
|
|
select * from information_schema.session_variables where variable_name='innodb_flush_sync';
|
|
--enable_warnings
|
|
set @@global.innodb_flush_sync=1;
|
|
select @@global.innodb_flush_sync;
|
|
--disable_warnings
|
|
select * from information_schema.global_variables where variable_name='innodb_flush_sync';
|
|
select * from information_schema.session_variables where variable_name='innodb_flush_sync';
|
|
--enable_warnings
|
|
set global innodb_flush_sync=0;
|
|
select @@global.innodb_flush_sync;
|
|
--disable_warnings
|
|
select * from information_schema.global_variables where variable_name='innodb_flush_sync';
|
|
select * from information_schema.session_variables where variable_name='innodb_flush_sync';
|
|
--enable_warnings
|
|
set @@global.innodb_flush_sync='ON';
|
|
select @@global.innodb_flush_sync;
|
|
--disable_warnings
|
|
select * from information_schema.global_variables where variable_name='innodb_flush_sync';
|
|
select * from information_schema.session_variables where variable_name='innodb_flush_sync';
|
|
--enable_warnings
|
|
--error ER_GLOBAL_VARIABLE
|
|
set session innodb_flush_sync='OFF';
|
|
--error ER_GLOBAL_VARIABLE
|
|
set @@session.innodb_flush_sync='ON';
|
|
|
|
#
|
|
# incorrect types
|
|
#
|
|
--error ER_WRONG_TYPE_FOR_VAR
|
|
set global innodb_flush_sync=1.1;
|
|
--error ER_WRONG_TYPE_FOR_VAR
|
|
set global innodb_flush_sync=1e1;
|
|
--error ER_WRONG_VALUE_FOR_VAR
|
|
set global innodb_flush_sync=2;
|
|
--error ER_WRONG_VALUE_FOR_VAR
|
|
set global innodb_flush_sync=-3;
|
|
select @@global.innodb_flush_sync;
|
|
--disable_warnings
|
|
select * from information_schema.global_variables where variable_name='innodb_flush_sync';
|
|
select * from information_schema.session_variables where variable_name='innodb_flush_sync';
|
|
--enable_warnings
|
|
--error ER_WRONG_VALUE_FOR_VAR
|
|
set global innodb_flush_sync='AUTO';
|
|
|
|
#
|
|
# Cleanup
|
|
#
|
|
|
|
SET @@global.innodb_flush_sync = @start_global_value;
|