mirror of
https://github.com/MariaDB/server.git
synced 2025-08-01 03:47:19 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
127 lines
2.7 KiB
Plaintext
127 lines
2.7 KiB
Plaintext
#----------------------------------------------------------
|
|
# Concurrency check for instrumentation of stored programs
|
|
#----------------------------------------------------------
|
|
|
|
|
|
--source include/big_test.inc
|
|
--source include/not_embedded.inc
|
|
--source include/have_perfschema.inc
|
|
--source include/no_protocol.inc
|
|
|
|
TRUNCATE TABLE performance_schema.events_statements_summary_by_program;
|
|
TRUNCATE TABLE performance_schema.events_statements_history;
|
|
|
|
--echo # concurrency check through multi connections
|
|
|
|
CREATE DATABASE db1;
|
|
CREATE DATABASE db2;
|
|
CREATE DATABASE db3;
|
|
|
|
# connection 1
|
|
connect (con1,localhost,root,,db1);
|
|
|
|
USE db1;
|
|
|
|
CREATE TABLE t1(
|
|
i INT NOT NULL
|
|
);
|
|
|
|
LOAD DATA INFILE '../../std_data/wl5766_data.txt' INTO TABLE t1;
|
|
|
|
DELIMITER |;
|
|
CREATE PROCEDURE proc()
|
|
BEGIN
|
|
INSERT INTO t1 SELECT * FROM t1;
|
|
END|
|
|
DELIMITER ;|
|
|
|
|
--send CALL proc();
|
|
|
|
# connection 2
|
|
connect (con2,localhost,root,,db2);
|
|
|
|
USE db2;
|
|
|
|
CREATE TABLE t2(
|
|
i INT NOT NULL
|
|
);
|
|
|
|
LOAD DATA INFILE '../../std_data/wl5766_data.txt' INTO TABLE t2;
|
|
DELIMITER |;
|
|
CREATE FUNCTION addition(x INT, y INT) RETURNS INT
|
|
BEGIN
|
|
INSERT INTO t2 SELECT * FROM t2;
|
|
RETURN x+y;
|
|
END|
|
|
DELIMITER ;|
|
|
|
|
--send SELECT addition(1234,9876);
|
|
|
|
# connection 3
|
|
connect (con3,localhost,root,,db3);
|
|
|
|
USE db3;
|
|
|
|
CREATE TABLE t(
|
|
i INT NOT NULL,
|
|
j INT
|
|
);
|
|
|
|
CREATE TABLE t3(
|
|
i INT NOT NULL
|
|
);
|
|
|
|
LOAD DATA INFILE '../../std_data/wl5766_data.txt' INTO TABLE t3;
|
|
INSERT INTO t VALUES ( 10,1000 );
|
|
CREATE TRIGGER trg AFTER INSERT ON t FOR EACH ROW
|
|
INSERT INTO t3 SELECT * FROM t3;
|
|
|
|
--send INSERT INTO t VALUES ( 20,2000);
|
|
|
|
connection con1;
|
|
--reap;
|
|
|
|
connection con2;
|
|
--reap;
|
|
|
|
connection con3;
|
|
--reap;
|
|
|
|
connection default;
|
|
|
|
--let $wait_condition=select count(*)=3 from information_schema.processlist where command='sleep';
|
|
--source include/wait_condition.inc
|
|
|
|
SELECT OBJECT_TYPE, OBJECT_SCHEMA, OBJECT_NAME, COUNT_STAR, COUNT_STATEMENTS
|
|
FROM performance_schema.events_statements_summary_by_program
|
|
WHERE OBJECT_SCHEMA='db1' OR OBJECT_SCHEMA='db2' OR OBJECT_SCHEMA='db3'
|
|
ORDER BY OBJECT_SCHEMA, OBJECT_NAME;
|
|
|
|
SELECT EVENT_NAME, SQL_TEXT, CURRENT_SCHEMA, OBJECT_TYPE, OBJECT_SCHEMA,
|
|
OBJECT_NAME, NESTING_EVENT_TYPE, NESTING_EVENT_LEVEL FROM
|
|
performance_schema.events_statements_history WHERE CURRENT_SCHEMA='db1'
|
|
OR CURRENT_SCHEMA='db2' OR CURRENT_SCHEMA='db3'
|
|
ORDER BY CURRENT_SCHEMA, OBJECT_NAME;
|
|
|
|
TRUNCATE TABLE performance_schema.events_statements_summary_by_program;
|
|
TRUNCATE TABLE performance_schema.events_statements_history;
|
|
|
|
--echo # Clean-up
|
|
|
|
DROP PROCEDURE db1.proc;
|
|
DROP FUNCTION db2.addition;
|
|
DROP TRIGGER db3.trg;
|
|
|
|
DROP TABLE db1.t1;
|
|
DROP TABLE db2.t2;
|
|
DROP TABLE db3.t3;
|
|
DROP TABLE db3.t;
|
|
|
|
DROP DATABASE db1;
|
|
DROP DATABASE db2;
|
|
DROP DATABASE db3;
|
|
|
|
disconnect con1;
|
|
disconnect con2;
|
|
disconnect con3;
|