mirror of
https://github.com/MariaDB/server.git
synced 2025-08-01 03:47:19 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
135 lines
4.3 KiB
Plaintext
135 lines
4.3 KiB
Plaintext
# Tests for PERFORMANCE_SCHEMA
|
|
|
|
--source include/not_embedded.inc
|
|
--source include/have_perfschema.inc
|
|
--source include/have_query_cache_disabled.inc
|
|
|
|
CREATE USER user1@localhost;
|
|
CREATE USER user2@localhost;
|
|
CREATE USER user3@localhost;
|
|
|
|
grant ALL on *.* to user1@localhost;
|
|
grant ALL on *.* to user2@localhost;
|
|
grant ALL on *.* to user3@localhost;
|
|
|
|
# To aggregate to accounts
|
|
#SET GLOBAL show_compatibility_56=0;
|
|
|
|
TRUNCATE TABLE performance_schema.accounts;
|
|
|
|
FLUSH PRIVILEGES;
|
|
|
|
CREATE TABLE test.t_range(a int, b int, PRIMARY KEY(a));
|
|
|
|
INSERT INTO test.t_range values (1, 1), (2,2), (3, 3), (4, 4), (5, 5);
|
|
INSERT INTO test.t_range values (6, 6), (7,7), (8, 8), (9, 9), (10, 10);
|
|
|
|
FLUSH GLOBAL STATUS;
|
|
|
|
let $initial= `SELECT VARIABLE_VALUE FROM performance_schema.global_status WHERE VARIABLE_NAME = 'Select_range'`;
|
|
|
|
# Causes Select_range to increment (+1)
|
|
--disable_ps2_protocol
|
|
SELECT * from test.t_range where (a >= 3) AND (a <= 5);
|
|
--enable_ps2_protocol
|
|
|
|
SELECT * from performance_schema.session_status
|
|
WHERE VARIABLE_NAME = 'Select_range';
|
|
|
|
--disable_query_log
|
|
eval SELECT VARIABLE_NAME, (VARIABLE_VALUE - $initial) AS DELTA from performance_schema.global_status WHERE VARIABLE_NAME = 'Select_range';
|
|
--enable_query_log
|
|
|
|
connect(con1, localhost, user1,,);
|
|
# Causes Select_range to increment (+1)
|
|
--disable_ps2_protocol
|
|
SELECT * from test.t_range where (a >= 3) AND (a <= 5);
|
|
--enable_ps2_protocol
|
|
|
|
SELECT * from performance_schema.session_status
|
|
WHERE VARIABLE_NAME = 'Select_range';
|
|
|
|
--disable_query_log
|
|
eval SELECT VARIABLE_NAME, (VARIABLE_VALUE - $initial) AS DELTA from performance_schema.global_status WHERE VARIABLE_NAME = 'Select_range';
|
|
--enable_query_log
|
|
|
|
connect(con2, localhost, user2,,);
|
|
# Causes Select_range to increment (+2)
|
|
--disable_ps2_protocol
|
|
SELECT * from test.t_range where (a >= 3) AND (a <= 5);
|
|
SELECT * from test.t_range where (a >= 4) AND (a <= 6);
|
|
--enable_ps2_protocol
|
|
|
|
SELECT * from performance_schema.session_status
|
|
WHERE VARIABLE_NAME = 'Select_range';
|
|
|
|
--disable_query_log
|
|
eval SELECT VARIABLE_NAME, (VARIABLE_VALUE - $initial) AS DELTA from performance_schema.global_status WHERE VARIABLE_NAME = 'Select_range';
|
|
--enable_query_log
|
|
|
|
connect(con3, localhost, user3,,);
|
|
# Causes Select_range to increment (+3)
|
|
--disable_ps2_protocol
|
|
SELECT * from test.t_range where (a >= 3) AND (a <= 5);
|
|
SELECT * from test.t_range where (a >= 4) AND (a <= 6);
|
|
SELECT * from test.t_range where (a >= 5) AND (a <= 7);
|
|
--enable_ps2_protocol
|
|
|
|
SELECT * from performance_schema.session_status
|
|
WHERE VARIABLE_NAME = 'Select_range';
|
|
|
|
--disable_query_log
|
|
eval SELECT VARIABLE_NAME, (VARIABLE_VALUE - $initial) AS DELTA from performance_schema.global_status WHERE VARIABLE_NAME = 'Select_range';
|
|
--enable_query_log
|
|
|
|
--connection default
|
|
|
|
--disable_query_log
|
|
eval SELECT VARIABLE_NAME, (VARIABLE_VALUE - $initial) AS DELTA from performance_schema.global_status WHERE VARIABLE_NAME = 'Select_range';
|
|
--enable_query_log
|
|
|
|
SELECT `USER`, `HOST`, VARIABLE_NAME, VARIABLE_VALUE
|
|
FROM performance_schema.status_by_account WHERE VARIABLE_NAME = 'Select_range'
|
|
AND `USER` LIKE 'user%'
|
|
ORDER BY `USER`;
|
|
|
|
--disconnect con1
|
|
--disconnect con2
|
|
|
|
--disable_query_log
|
|
eval SELECT VARIABLE_NAME, (VARIABLE_VALUE - $initial) AS DELTA from performance_schema.global_status WHERE VARIABLE_NAME = 'Select_range';
|
|
--enable_query_log
|
|
|
|
TRUNCATE TABLE performance_schema.accounts;
|
|
|
|
--disable_query_log
|
|
eval SELECT VARIABLE_NAME, (VARIABLE_VALUE - $initial) AS DELTA from performance_schema.global_status WHERE VARIABLE_NAME = 'Select_range';
|
|
--enable_query_log
|
|
|
|
--disconnect con3
|
|
|
|
--disable_query_log
|
|
eval SELECT VARIABLE_NAME, (VARIABLE_VALUE - $initial) AS DELTA from performance_schema.global_status WHERE VARIABLE_NAME = 'Select_range';
|
|
--enable_query_log
|
|
|
|
# Make sure TRUNCATE on accounts does not add to global_status
|
|
TRUNCATE TABLE performance_schema.accounts;
|
|
|
|
--disable_query_log
|
|
eval SELECT VARIABLE_NAME, (VARIABLE_VALUE - $initial) AS DELTA from performance_schema.global_status WHERE VARIABLE_NAME = 'Select_range';
|
|
--enable_query_log
|
|
|
|
DROP TABLE test.t_range;
|
|
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM user1@localhost;
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM user2@localhost;
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM user3@localhost;
|
|
DROP USER user1@localhost;
|
|
DROP USER user2@localhost;
|
|
DROP USER user3@localhost;
|
|
|
|
#SET GLOBAL show_compatibility_56=1;
|
|
|
|
FLUSH PRIVILEGES;
|
|
|