mirror of
https://github.com/MariaDB/server.git
synced 2025-08-01 03:47:19 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
40 lines
863 B
Plaintext
40 lines
863 B
Plaintext
--source include/have_innodb.inc
|
|
SET default_storage_engine=innodb;
|
|
--source include/gis_generic.inc
|
|
--source include/gis_keys.inc
|
|
|
|
#
|
|
# Bug #15680 (SPATIAL key in innodb)
|
|
#
|
|
#--error ER_TABLE_CANT_HANDLE_SPKEYS
|
|
create table t1 (g geometry not null, spatial gk(g)) engine=innodb;
|
|
|
|
DROP TABLE t1;
|
|
|
|
# Test read uncommitted
|
|
create table t1 (c1 int, c2 geometry not null, spatial index (c2))engine=innodb;
|
|
|
|
connect (a,localhost,root,,);
|
|
connection a;
|
|
|
|
start transaction;
|
|
insert into t1 values(1, Point(1,1));
|
|
|
|
|
|
connect (con1,localhost,root,,);
|
|
connection con1;
|
|
set @g1 = ST_GeomFromText('Polygon((0 0,0 100,100 100,100 0,0 0))');
|
|
set transaction isolation level read uncommitted;
|
|
--disable_ps2_protocol
|
|
select count(*) from t1 where ST_Within(t1.c2, @g1);
|
|
--enable_ps2_protocol
|
|
disconnect con1;
|
|
connection a;
|
|
commit;
|
|
disconnect a;
|
|
connection default;
|
|
drop table t1;
|
|
|
|
|
|
|