mirror of
https://github.com/MariaDB/server.git
synced 2025-08-01 03:47:19 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
45 lines
920 B
Plaintext
45 lines
920 B
Plaintext
--source include/have_innodb.inc
|
|
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (b INT) ENGINE=InnoDB;
|
|
CREATE TABLE t3 (c INT) ENGINE=InnoDB;
|
|
|
|
--delimiter $$
|
|
CREATE TRIGGER tr BEFORE INSERT ON t3 FOR EACH ROW BEGIN SAVEPOINT sv; INSERT INTO t2 VALUES (0); END $$
|
|
--delimiter ;
|
|
|
|
START TRANSACTION;
|
|
DELETE FROM t1;
|
|
|
|
connect (con1,localhost,root,,test);
|
|
START TRANSACTION;
|
|
INSERT INTO t2 VALUES (2);
|
|
UPDATE t2 SET b = b+1;
|
|
|
|
--send
|
|
INSERT INTO t1 VALUES (1);
|
|
|
|
connection default;
|
|
let $wait_condition=
|
|
select count(*) = 1 from information_schema.processlist
|
|
where state = 'update' and info = 'INSERT INTO t1 VALUES (1)'
|
|
--source include/wait_condition.inc
|
|
|
|
--error ER_LOCK_DEADLOCK
|
|
INSERT INTO t3 VALUES (2);
|
|
COMMIT;
|
|
|
|
connection con1;
|
|
reap;
|
|
COMMIT;
|
|
disconnect con1;
|
|
|
|
connection default;
|
|
SELECT * FROM t1;
|
|
SELECT * FROM t2;
|
|
SELECT * FROM t3;
|
|
|
|
DROP TABLE t1, t2, t3;
|
|
--error ER_TRG_DOES_NOT_EXIST
|
|
DROP TRIGGER tr;
|