mirror of
https://github.com/MariaDB/server.git
synced 2025-08-01 03:47:19 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
50 lines
1.2 KiB
Plaintext
50 lines
1.2 KiB
Plaintext
--source include/have_innodb.inc
|
|
--source include/have_debug.inc
|
|
--source include/have_debug_sync.inc
|
|
--source include/not_embedded.inc
|
|
|
|
--echo #
|
|
--echo # MDEV-35508: Race condition between purge and secondary index INSERT or UPDATE
|
|
--echo #
|
|
|
|
SET @old_debug_dbug = @@global.debug_dbug;
|
|
|
|
CREATE TABLE t1(col1 INT PRIMARY KEY, col2 int, KEY k1(col2)) ENGINE=Innodb;
|
|
INSERT INTO t1 VALUES(1, 100);
|
|
|
|
CREATE TABLE t2(col1 INT PRIMARY KEY) Engine=Innodb;
|
|
--source include/wait_all_purged.inc
|
|
|
|
START TRANSACTION;
|
|
INSERT INTO t2 VALUES(10);
|
|
|
|
SET DEBUG_SYNC='RESET';
|
|
|
|
SET GLOBAL debug_dbug= "+d,btr_force_pessimistic_delete";
|
|
SET GLOBAL debug_dbug= "+d,enable_row_purge_sec_tree_sync";
|
|
|
|
--connect (con1,localhost,root)
|
|
UPDATE t1 SET col2 = 200 WHERE col1 = 1;
|
|
|
|
--connection default
|
|
SET DEBUG_SYNC= 'now WAIT_FOR purge_sec_tree_begin';
|
|
SET GLOBAL debug_dbug= "-d,enable_row_purge_sec_tree_sync";
|
|
|
|
UPDATE t1 SET col2 = 100 WHERE col1 = 1;
|
|
SET DEBUG_SYNC= 'now SIGNAL purge_sec_tree_execute';
|
|
|
|
COMMIT;
|
|
--source include/wait_all_purged.inc
|
|
|
|
--disconnect con1
|
|
|
|
SELECT * FROM t1;
|
|
CHECK TABLE t1;
|
|
DROP TABLE t1;
|
|
|
|
SELECT * FROM t2;
|
|
DROP TABLE t2;
|
|
|
|
SET @@GLOBAL.debug_dbug = @old_debug_dbug;
|
|
SET DEBUG_SYNC='RESET';
|