mirror of
https://github.com/MariaDB/server.git
synced 2025-08-01 03:47:19 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
58 lines
1.9 KiB
Plaintext
58 lines
1.9 KiB
Plaintext
--source include/have_innodb.inc
|
|
--source include/have_debug.inc
|
|
--source include/have_debug_sync.inc
|
|
|
|
CREATE TABLE t (pk int PRIMARY KEY, c varchar(10))
|
|
STATS_PERSISTENT=0 ENGINE=InnoDB;
|
|
INSERT INTO t VALUES (10, "0123456789");
|
|
|
|
--connection default
|
|
BEGIN;
|
|
SELECT * FROM t WHERE c = 10 FOR UPDATE;
|
|
|
|
--connect(trx2, localhost,root,,)
|
|
BEGIN;
|
|
SET DEBUG_SYNC="lock_wait_start SIGNAL trx2_start_waiting";
|
|
SET DEBUG_SYNC="lock_wait_end SIGNAL trx2_wait_end WAIT_FOR trx2_cont_upd";
|
|
SET DEBUG_SYNC="lock_rec_store_on_page_infimum_end SIGNAL trx2_moved_locks WAIT_FOR trx2_cont";
|
|
#################
|
|
# We need to update clustered record without changing ordering fields and
|
|
# changing the size of non-ordering fields to cause locks moving from deleted
|
|
# record to infimum.
|
|
###
|
|
--send UPDATE t SET c = NULL WHERE pk = 10
|
|
|
|
|
|
--connect(trx3, localhost,root,,)
|
|
SET DEBUG_SYNC="now WAIT_FOR trx2_start_waiting";
|
|
#################
|
|
# The condition variable waiting in lock_wait() must be finished by timeout
|
|
###
|
|
SET innodb_lock_wait_timeout=1;
|
|
BEGIN;
|
|
SET DEBUG_SYNC="lock_wait_start SIGNAL trx3_start_waiting WAIT_FOR trx3_cont_waiting";
|
|
SET DEBUG_SYNC="lock_sys_t_cancel_enter SIGNAL trx3_cancel_enter WAIT_FOR trx3_cont_cancel_waiting";
|
|
--send UPDATE t SET c = "abcdefghij" WHERE pk = 10
|
|
|
|
--connection default
|
|
SET DEBUG_SYNC="now WAIT_FOR trx3_start_waiting";
|
|
COMMIT;
|
|
SET DEBUG_SYNC="now WAIT_FOR trx2_wait_end";
|
|
SET DEBUG_SYNC="now SIGNAL trx3_cont_waiting";
|
|
SET DEBUG_SYNC="now WAIT_FOR trx3_cancel_enter";
|
|
SET DEBUG_SYNC="now SIGNAL trx2_cont_upd";
|
|
SET DEBUG_SYNC="now WAIT_FOR trx2_moved_locks";
|
|
#################
|
|
# If the bug is not fixed, there will be assertion failure here, because trx2
|
|
# moved trx3 lock from deleted record to infimum when trx3 tried to cancel the
|
|
# lock.
|
|
###
|
|
SET DEBUG_SYNC="now SIGNAL trx3_cont_cancel_waiting";
|
|
SET DEBUG_SYNC="now SIGNAL trx2_cont";
|
|
|
|
--disconnect trx2
|
|
--disconnect trx3
|
|
--connection default
|
|
SET DEBUG_SYNC="RESET";
|
|
DROP TABLE t;
|