mirror of
https://github.com/MariaDB/server.git
synced 2025-08-01 03:47:19 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
79 lines
2.2 KiB
Plaintext
79 lines
2.2 KiB
Plaintext
--source include/have_innodb.inc
|
|
#
|
|
# Testcase for InnoDB
|
|
# Bug#42419 Server crash with "Pure virtual method called" on two concurrent connections
|
|
#
|
|
|
|
--disable_query_log
|
|
call mtr.add_suppression("InnoDB: Transaction was aborted due to ");
|
|
--enable_query_log
|
|
|
|
--source include/not_embedded.inc
|
|
|
|
let $innodb_lock_wait_timeout= query_get_value(SHOW VARIABLES LIKE 'innodb_lock_wait_timeout%', Value, 1);
|
|
if ($innodb_lock_wait_timeout < 10)
|
|
{
|
|
--echo # innodb_lock_wait_timeout must be >= 10 seconds
|
|
--echo # so that this test can work all time fine on an overloaded testing box
|
|
SHOW VARIABLES LIKE 'innodb_lock_wait_timeout';
|
|
exit;
|
|
}
|
|
|
|
# First session
|
|
connection default;
|
|
|
|
|
|
--enable_warnings
|
|
CREATE TABLE t1 (a INT AUTO_INCREMENT PRIMARY KEY, b INT) ENGINE = InnoDB;
|
|
|
|
INSERT INTO t1 VALUES (1,1),(2,2),(3,3);
|
|
COMMIT;
|
|
SET AUTOCOMMIT = 0;
|
|
|
|
CREATE TEMPORARY TABLE t1_tmp ( b INT );
|
|
|
|
INSERT INTO t1_tmp (b) SELECT b FROM t1 WHERE a = 3;
|
|
INSERT INTO t1_tmp (b) SELECT b FROM t1 WHERE a = 2;
|
|
|
|
# Second session
|
|
connect (user2,localhost,root,,,$MASTER_MYPORT,$MASTER_MYSOCK);
|
|
|
|
SET AUTOCOMMIT = 0;
|
|
|
|
CREATE TEMPORARY TABLE t2_tmp ( a int, new_a int );
|
|
INSERT INTO t2_tmp VALUES (1,51),(2,52),(3,53);
|
|
|
|
UPDATE t1 SET a = (SELECT new_a FROM t2_tmp WHERE t2_tmp.a = t1.a) WHERE a = 1;
|
|
send
|
|
UPDATE t1 SET a = (SELECT new_a FROM t2_tmp WHERE t2_tmp.a = t1.a) WHERE a = 2;
|
|
|
|
# The last update will wait for a lock held by the first session
|
|
|
|
# First session
|
|
connection default;
|
|
|
|
# Poll till the UPDATE of the second session waits for lock
|
|
let $show_statement= SHOW PROCESSLIST;
|
|
let $field= State;
|
|
let $condition= = 'Updating';
|
|
--source include/wait_show_condition.inc
|
|
|
|
# If the testing box is overloaded and innodb_lock_wait_timeout is too small
|
|
# we might get here ER_LOCK_WAIT_TIMEOUT.
|
|
--error ER_LOCK_DEADLOCK
|
|
INSERT INTO t1_tmp (b) SELECT b FROM t1 WHERE a = 1;
|
|
|
|
# Second session
|
|
connection user2;
|
|
--echo Reap the server message for connection user2 UPDATE t1 ...
|
|
reap;
|
|
|
|
# The server crashed when executing this UPDATE or the succeeding SQL command.
|
|
UPDATE t1 SET a = (SELECT new_a FROM t2_tmp WHERE t2_tmp.a = t1.a) WHERE a = 3;
|
|
|
|
connection default;
|
|
disconnect user2;
|
|
DROP TABLE t1;
|
|
|
|
call mtr.add_suppression("Deadlock found when trying to get lock; try restarting transaction");
|