mirror of
https://github.com/MariaDB/server.git
synced 2025-08-01 03:47:19 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
30 lines
809 B
Plaintext
30 lines
809 B
Plaintext
--source include/have_innodb.inc
|
|
--source include/have_debug_sync.inc
|
|
|
|
connect (con1,localhost,root,,);
|
|
|
|
connection default;
|
|
|
|
CREATE TABLE t (a INT PRIMARY KEY, b INT NOT NULL) ENGINE=InnoDB;
|
|
INSERT INTO t VALUES(1,2),(2,3);
|
|
|
|
SET DEBUG_SYNC='alter_table_inplace_after_lock_downgrade SIGNAL do WAIT_FOR m';
|
|
SET DEBUG_SYNC='innodb_after_inplace_alter_table SIGNAL scanned WAIT_FOR done';
|
|
--send
|
|
CREATE INDEX tb ON t(b);
|
|
|
|
connection con1;
|
|
SET DEBUG_SYNC='now WAIT_FOR do';
|
|
SET DEBUG_SYNC='row_update_for_mysql_error SIGNAL m WAIT_FOR scanned';
|
|
--error ER_DUP_ENTRY
|
|
UPDATE t SET a=2 WHERE a=1;
|
|
call mtr.add_suppression('InnoDB: record in index .*tb was not found on rollback, trying to insert');
|
|
SET DEBUG_SYNC='now SIGNAL done';
|
|
|
|
disconnect con1;
|
|
|
|
connection default;
|
|
reap;
|
|
SET DEBUG_SYNC='RESET';
|
|
DROP TABLE t;
|