mirror of
https://github.com/MariaDB/server.git
synced 2025-08-01 03:47:19 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
155 lines
4.1 KiB
Plaintext
155 lines
4.1 KiB
Plaintext
--source include/innodb_page_size.inc
|
|
|
|
CREATE TABLE t (c1 INT PRIMARY KEY, c2 INT NOT NULL, c3 INT) ENGINE=InnoDB;
|
|
INSERT INTO t VALUES (1,2,3),(4,5,6),(7,8,9);
|
|
|
|
--enable_info
|
|
# This one will be a no-op.
|
|
# MySQL should perhaps issue an error, because it refuses to modify
|
|
# the PRIMARY KEY column c1 from NOT NULL to NULL.
|
|
ALTER TABLE t CHANGE c1 c1 INT NULL FIRST, ALGORITHM=INPLACE;
|
|
|
|
# NULL -> NOT NULL only allowed INPLACE if strict sql_mode is on.
|
|
ALTER TABLE t MODIFY c3 INT NOT NULL, ALGORITHM=INPLACE;
|
|
|
|
# Request some conflicting changes for a single column.
|
|
--error ER_BAD_FIELD_ERROR
|
|
ALTER TABLE t CHANGE c2 c2 INT, CHANGE c2 c2 INT NOT NULL;
|
|
--error ER_BAD_FIELD_ERROR
|
|
ALTER TABLE t MODIFY c2 INT, MODIFY c2 INT NOT NULL;
|
|
--error ER_BAD_FIELD_ERROR
|
|
ALTER TABLE t MODIFY c2 INT UNSIGNED, MODIFY c2 INT;
|
|
--error ER_BAD_FIELD_ERROR
|
|
ALTER TABLE t MODIFY c2 CHAR(1) NOT NULL, MODIFY c2 INT NOT NULL;
|
|
|
|
# No-ops.
|
|
ALTER TABLE t CHANGE c2 c2 INT NOT NULL;
|
|
ALTER TABLE t MODIFY c2 INT NOT NULL;
|
|
--disable_info
|
|
|
|
connect (con1,localhost,root,,);
|
|
|
|
--error ER_BAD_NULL_ERROR
|
|
UPDATE t SET c2=NULL;
|
|
|
|
SELECT * FROM t;
|
|
|
|
connection default;
|
|
|
|
# This should change the column to NULL.
|
|
ALTER TABLE t MODIFY c2 INT, ALGORITHM=INPLACE;
|
|
|
|
connection con1;
|
|
BEGIN;
|
|
UPDATE t SET c2=NULL;
|
|
SELECT * FROM t;
|
|
ROLLBACK;
|
|
SELECT * FROM t;
|
|
|
|
disconnect con1;
|
|
connection default;
|
|
|
|
# This should be no-op.
|
|
ALTER TABLE t MODIFY c2 INT NULL, ALGORITHM=INPLACE;
|
|
|
|
--replace_column 1 # 5 #
|
|
SELECT * FROM INFORMATION_SCHEMA.INNODB_SYS_TABLES
|
|
WHERE NAME='test/t';
|
|
|
|
DROP TABLE t;
|
|
|
|
CREATE TABLE t1(c1 INT) ENGINE=InnoDB;
|
|
ALTER TABLE t1 ADD CONSTRAINT UNIQUE KEY i1(c1);
|
|
ALTER TABLE t1 CHANGE c1 c1 INT NOT NULL,ADD KEY(c1);
|
|
DROP TABLE t1;
|
|
|
|
--echo #
|
|
--echo # MDEV-18732 InnoDB: ALTER IGNORE returns error for NULL
|
|
--echo #
|
|
|
|
CREATE TABLE t1(c INT) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES (NULL);
|
|
--enable_info
|
|
ALTER IGNORE TABLE t1 MODIFY c INT NOT NULL;
|
|
--disable_info
|
|
--error ER_BAD_NULL_ERROR
|
|
INSERT INTO t1 VALUES (NULL);
|
|
SELECT * FROM t1;
|
|
DROP TABLE t1;
|
|
|
|
CREATE TABLE t1(c INT) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES (NULL),(1),(1);
|
|
--enable_info
|
|
ALTER IGNORE TABLE t1 ADD UNIQUE(c);
|
|
ALTER IGNORE TABLE t1 ADD PRIMARY KEY(c);
|
|
--disable_info
|
|
SELECT * FROM t1;
|
|
DROP TABLE t1;
|
|
|
|
CREATE TABLE t1(c INT, g INT AS (c) PERSISTENT) ENGINE=InnoDB;
|
|
CREATE TABLE t2(c INT, v INT AS (c) VIRTUAL) ENGINE=InnoDB;
|
|
CREATE TABLE t3(c INT, v INT AS (c) VIRTUAL, INDEX(v)) ENGINE=InnoDB;
|
|
INSERT INTO t1 SET c=NULL;
|
|
INSERT INTO t2 SET c=NULL;
|
|
INSERT INTO t3 SET c=NULL;
|
|
SET @old_sql_mode = @@sql_mode;
|
|
# Allow lossy conversions of data
|
|
SET sql_mode = '';
|
|
--enable_info
|
|
ALTER TABLE t1 MODIFY c INT NOT NULL;
|
|
ALTER TABLE t2 MODIFY c INT NOT NULL;
|
|
ALTER TABLE t3 MODIFY c INT NOT NULL;
|
|
--disable_info
|
|
SET sql_mode = @old_sql_mode;
|
|
SELECT * FROM t1;
|
|
SELECT * FROM t2;
|
|
SELECT * FROM t3;
|
|
SELECT v FROM t3 FORCE INDEX(v);
|
|
CHECK TABLE t1,t2,t3;
|
|
DROP TABLE t1,t2,t3;
|
|
|
|
CREATE TABLE t1(c INT, g INT AS (c) PERSISTENT) ENGINE=InnoDB;
|
|
CREATE TABLE t2(c INT, v INT AS (c) VIRTUAL) ENGINE=InnoDB;
|
|
CREATE TABLE t3(c INT, v INT AS (c) VIRTUAL, INDEX(v)) ENGINE=InnoDB;
|
|
INSERT INTO t1 SET c=NULL;
|
|
INSERT INTO t2 SET c=NULL;
|
|
INSERT INTO t3 SET c=NULL;
|
|
--enable_info
|
|
ALTER IGNORE TABLE t1 MODIFY c INT NOT NULL;
|
|
ALTER IGNORE TABLE t2 MODIFY c INT NOT NULL;
|
|
ALTER IGNORE TABLE t3 MODIFY c INT NOT NULL;
|
|
--disable_info
|
|
SELECT * FROM t1;
|
|
SELECT * FROM t2;
|
|
SELECT * FROM t3;
|
|
SELECT v FROM t3 FORCE INDEX(v);
|
|
CHECK TABLE t1,t2,t3;
|
|
DROP TABLE t1,t2,t3;
|
|
|
|
CREATE TABLE t1(c INT, g INT AS (c) PERSISTENT) ENGINE=InnoDB;
|
|
CREATE TABLE t2(c INT, v INT AS (c) VIRTUAL) ENGINE=InnoDB;
|
|
CREATE TABLE t3(c INT, v INT AS (c) VIRTUAL, INDEX(v)) ENGINE=InnoDB;
|
|
INSERT INTO t1 SET c=NULL;
|
|
INSERT INTO t2 SET c=NULL;
|
|
INSERT INTO t3 SET c=NULL;
|
|
--enable_info
|
|
--error WARN_DATA_TRUNCATED
|
|
ALTER TABLE t1 MODIFY c INT NOT NULL;
|
|
--error WARN_DATA_TRUNCATED
|
|
ALTER TABLE t2 MODIFY c INT NOT NULL;
|
|
--error WARN_DATA_TRUNCATED
|
|
ALTER TABLE t3 MODIFY c INT NOT NULL;
|
|
--disable_info
|
|
UPDATE t1 SET c=0;
|
|
UPDATE t2 SET c=0;
|
|
UPDATE t3 SET c=0;
|
|
--enable_info
|
|
ALTER TABLE t1 MODIFY c INT NOT NULL;
|
|
ALTER TABLE t2 MODIFY c INT NOT NULL;
|
|
ALTER TABLE t3 MODIFY c INT NOT NULL;
|
|
--disable_info
|
|
SELECT * FROM t1;
|
|
SELECT * FROM t2;
|
|
SELECT * FROM t3;
|
|
DROP TABLE t1,t2,t3;
|