mirror of
https://github.com/MariaDB/server.git
synced 2025-08-08 11:22:35 +03:00
84da20e658
This is actually an existing problem in the old binlog implementation, and this patch is applicable to old binlog also. The problem is that RESET MASTER can run concurrently with binlog dump threads / connected slaves. This will remove the binlog from under the feet of the reader, which can cause all sorts of strange behaviour. This patch fixes the problem by disallowing to run RESET MASTER when dump threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is thrown in this case, user must stop slaves and/or kill dump threads to make the RESET MASTER go through. A slave that connects in the middle of RESET MASTER will wait for it to complete. Fix a lot of test cases to kill any lingering dump threads before doing RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
69 lines
1.9 KiB
Plaintext
69 lines
1.9 KiB
Plaintext
# Test for Bug #41902 MYSQL_BIN_LOG::reset_logs() doesn't call my_error()
|
|
# in face of an error
|
|
#
|
|
|
|
source include/have_debug.inc;
|
|
source include/master-slave.inc;
|
|
|
|
#
|
|
# test checks that
|
|
# a. there is no crash when find_log_pos() returns with an error
|
|
# that tests expect to receive;
|
|
# b. in the case of multiple error messages the first error message is
|
|
# reported to the user and others are available as warnings.
|
|
#
|
|
|
|
connection slave;
|
|
stop slave;
|
|
SET @saved_dbug = @@GLOBAL.debug_dbug;
|
|
SET @@debug_dbug="d,simulate_find_log_pos_error";
|
|
|
|
--error ER_UNKNOWN_TARGET_BINLOG
|
|
reset slave;
|
|
show warnings;
|
|
|
|
SET @@debug_dbug="";
|
|
reset slave;
|
|
change master to master_host='dummy';
|
|
|
|
SET @@debug_dbug="d,simulate_find_log_pos_error";
|
|
|
|
--error ER_UNKNOWN_TARGET_BINLOG
|
|
change master to master_host='dummy';
|
|
|
|
SET @@debug_dbug="";
|
|
reset slave;
|
|
change master to master_host='dummy';
|
|
|
|
connection master;
|
|
--source include/kill_binlog_dump_threads.inc
|
|
SET @saved_dbug_m = @@global.debug_dbug;
|
|
SET @@debug_dbug="d,simulate_find_log_pos_error";
|
|
--error ER_UNKNOWN_TARGET_BINLOG
|
|
reset master;
|
|
|
|
SET @@debug_dbug="";
|
|
reset master;
|
|
|
|
SET @@debug_dbug="d,simulate_find_log_pos_error";
|
|
--error ER_UNKNOWN_TARGET_BINLOG
|
|
purge binary logs to 'master-bin.000001';
|
|
|
|
SET @@debug_dbug="";
|
|
purge binary logs to 'master-bin.000001';
|
|
|
|
--disable_query_log
|
|
call mtr.add_suppression("Failed to locate old binlog or relay log files");
|
|
call mtr.add_suppression("MYSQL_BIN_LOG::purge_logs was called with file ..master-bin.000001 not listed in the index");
|
|
set @@global.debug_dbug = @saved_dbug_m;
|
|
connection slave;
|
|
call mtr.add_suppression("Failed to locate old binlog or relay log files");
|
|
call mtr.add_suppression("MYSQL_BIN_LOG::purge_logs was called with file ..master-bin.000001 not listed in the index");
|
|
--enable_query_log
|
|
SET @@GLOBAL.debug_dbug = @saved_dbug;
|
|
|
|
--echo ==== clean up ====
|
|
CHANGE MASTER TO MASTER_HOST = '127.0.0.1';
|
|
--let $rpl_only_running_threads= 1
|
|
--source include/rpl_end.inc
|