mirror of
https://github.com/MariaDB/server.git
synced 2025-08-08 11:22:35 +03:00
84da20e658
This is actually an existing problem in the old binlog implementation, and this patch is applicable to old binlog also. The problem is that RESET MASTER can run concurrently with binlog dump threads / connected slaves. This will remove the binlog from under the feet of the reader, which can cause all sorts of strange behaviour. This patch fixes the problem by disallowing to run RESET MASTER when dump threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is thrown in this case, user must stop slaves and/or kill dump threads to make the RESET MASTER go through. A slave that connects in the middle of RESET MASTER will wait for it to complete. Fix a lot of test cases to kill any lingering dump threads before doing RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
39 lines
1.2 KiB
Plaintext
39 lines
1.2 KiB
Plaintext
include/master-slave.inc
|
|
[connection master]
|
|
connection slave;
|
|
stop slave;
|
|
SET @saved_dbug = @@GLOBAL.debug_dbug;
|
|
SET @@debug_dbug="d,simulate_find_log_pos_error";
|
|
reset slave;
|
|
ERROR HY000: Target log not found in binlog index
|
|
show warnings;
|
|
Level Code Message
|
|
Error 1373 Target log not found in binlog index
|
|
Error 1371 Failed purging old relay logs: Failed during log reset
|
|
SET @@debug_dbug="";
|
|
reset slave;
|
|
change master to master_host='dummy';
|
|
SET @@debug_dbug="d,simulate_find_log_pos_error";
|
|
change master to master_host='dummy';
|
|
ERROR HY000: Target log not found in binlog index
|
|
SET @@debug_dbug="";
|
|
reset slave;
|
|
change master to master_host='dummy';
|
|
connection master;
|
|
include/kill_binlog_dump_threads.inc
|
|
SET @saved_dbug_m = @@global.debug_dbug;
|
|
SET @@debug_dbug="d,simulate_find_log_pos_error";
|
|
reset master;
|
|
ERROR HY000: Target log not found in binlog index
|
|
SET @@debug_dbug="";
|
|
reset master;
|
|
SET @@debug_dbug="d,simulate_find_log_pos_error";
|
|
purge binary logs to 'master-bin.000001';
|
|
ERROR HY000: Target log not found in binlog index
|
|
SET @@debug_dbug="";
|
|
purge binary logs to 'master-bin.000001';
|
|
SET @@GLOBAL.debug_dbug = @saved_dbug;
|
|
==== clean up ====
|
|
CHANGE MASTER TO MASTER_HOST = '127.0.0.1';
|
|
include/rpl_end.inc
|