mirror of
https://github.com/MariaDB/server.git
synced 2025-08-08 11:22:35 +03:00
84da20e658
This is actually an existing problem in the old binlog implementation, and this patch is applicable to old binlog also. The problem is that RESET MASTER can run concurrently with binlog dump threads / connected slaves. This will remove the binlog from under the feet of the reader, which can cause all sorts of strange behaviour. This patch fixes the problem by disallowing to run RESET MASTER when dump threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is thrown in this case, user must stop slaves and/or kill dump threads to make the RESET MASTER go through. A slave that connects in the middle of RESET MASTER will wait for it to complete. Fix a lot of test cases to kill any lingering dump threads before doing RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
64 lines
1.5 KiB
Plaintext
64 lines
1.5 KiB
Plaintext
#
|
|
# MDEV-28053 - Sysbench data load crashes Galera secondary node in
|
|
# async master slave setup
|
|
#
|
|
# Setup: node 3 is a regular MariaDB server, nodes 1 and 2 are members
|
|
# of a Galera cluster. Node 2 connects to node 3 through async replication.
|
|
#
|
|
# Test uses multiple parallel async applier threads (see MDEV-28053.cnf)
|
|
#
|
|
|
|
--source include/have_innodb.inc
|
|
--source include/galera_cluster.inc
|
|
|
|
--connect node_3, 127.0.0.1, root, , test, $NODE_MYPORT_3
|
|
|
|
--connection node_3
|
|
CREATE TABLE t1 (f1 INTEGER PRIMARY KEY AUTO_INCREMENT) ENGINE=InnoDB;
|
|
|
|
#
|
|
# Execute a few INSERTs, to simulate sysbench data load phase
|
|
#
|
|
--let $counter=100
|
|
--disable_query_log
|
|
while ($counter) {
|
|
--connection node_3
|
|
INSERT INTO t1 VALUES();
|
|
--dec $counter
|
|
}
|
|
--enable_query_log
|
|
--let gtid = `SELECT @@last_gtid`
|
|
|
|
#
|
|
# Start async replication on node 2.
|
|
# If bug is present, expect a crash when applying
|
|
# events concurrently.
|
|
#
|
|
--connection node_2
|
|
--disable_query_log
|
|
--disable_result_log
|
|
--eval CHANGE MASTER TO MASTER_HOST='127.0.0.1', MASTER_USER='root', MASTER_SSL_VERIFY_SERVER_CERT=0, MASTER_PORT=$NODE_MYPORT_3;
|
|
START SLAVE;
|
|
|
|
--eval SELECT MASTER_GTID_WAIT('$gtid', 600)
|
|
--enable_result_log
|
|
--enable_query_log
|
|
|
|
#
|
|
# Cleanup
|
|
#
|
|
--connection node_3
|
|
DROP TABLE t1;
|
|
|
|
--connection node_2
|
|
--let $wait_condition = SELECT COUNT(*) = 0 FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = 't1';
|
|
--source include/wait_condition.inc
|
|
|
|
--connection node_2
|
|
STOP SLAVE;
|
|
RESET SLAVE ALL;
|
|
|
|
--connection node_3
|
|
--source include/kill_binlog_dump_threads.inc
|
|
RESET MASTER;
|