mirror of
https://github.com/MariaDB/server.git
synced 2025-08-07 00:04:31 +03:00
84da20e658
This is actually an existing problem in the old binlog implementation, and this patch is applicable to old binlog also. The problem is that RESET MASTER can run concurrently with binlog dump threads / connected slaves. This will remove the binlog from under the feet of the reader, which can cause all sorts of strange behaviour. This patch fixes the problem by disallowing to run RESET MASTER when dump threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is thrown in this case, user must stop slaves and/or kill dump threads to make the RESET MASTER go through. A slave that connects in the middle of RESET MASTER will wait for it to complete. Fix a lot of test cases to kill any lingering dump threads before doing RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
31 lines
950 B
PHP
31 lines
950 B
PHP
#
|
|
# The include file runs RESET ALL for every replication connection
|
|
# currently present in SHOW FULL SLAVE STATUS output on the server,
|
|
# and also runs RESET MASTER on the same server.
|
|
#
|
|
|
|
--let $include_filename= reset_master_slave.inc
|
|
--source include/begin_include_file.inc
|
|
|
|
--disable_query_log
|
|
--disable_result_log
|
|
--disable_warnings
|
|
--let $default_master = `SELECT @@default_master_connection`
|
|
--let $con_name = query_get_value(show all slaves status, Connection_name, 1)
|
|
while ($con_name != 'No such row')
|
|
{
|
|
eval set default_master_connection = '$con_name';
|
|
stop slave;
|
|
--source include/wait_for_slave_to_stop.inc
|
|
reset slave all;
|
|
--let $con_name = query_get_value(show all slaves status, Connection_name, 1)
|
|
}
|
|
|
|
--source include/kill_binlog_dump_threads.inc
|
|
--error 0,ER_FLUSH_MASTER_BINLOG_CLOSED
|
|
reset master;
|
|
set global gtid_slave_pos='';
|
|
eval set default_master_connection = '$default_master';
|
|
--source include/end_include_file.inc
|
|
|