mirror of
https://github.com/MariaDB/server.git
synced 2025-08-07 00:04:31 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
52 lines
1.1 KiB
Plaintext
52 lines
1.1 KiB
Plaintext
#
|
|
# INSERT DELAYED
|
|
#
|
|
|
|
--source have_engine.inc
|
|
|
|
if (`SELECT @@log_bin AND @@binlog_format IN ('statement','mixed')`)
|
|
{
|
|
--source cleanup_engine.inc
|
|
--skip # INSERT DELAYED does not work with binlog format STATEMENT or MIXED
|
|
}
|
|
|
|
--let $create_definition = a $int_col, b $char_col
|
|
--source create_table.inc
|
|
INSERT INTO t1 (a,b) VALUES (1,'f'),(2,'b');
|
|
|
|
LOCK TABLE t1 READ;
|
|
if ($mysql_errname)
|
|
{
|
|
--let $functionality = LOCK TABLE .. READ
|
|
--source unexpected_result.inc
|
|
}
|
|
if (!$mysql_errname)
|
|
{
|
|
--connect (con0,localhost,root,,)
|
|
SET lock_wait_timeout = 1;
|
|
INSERT DELAYED INTO t1 (a,b) VALUES (3,'c');
|
|
if ($mysql_errname)
|
|
{
|
|
--let $functionality = INSERT DELAYED
|
|
--source unexpected_result.inc
|
|
}
|
|
INSERT DELAYED INTO t1 SET a=4, b='d';
|
|
# DELAYED is ignored with INSERT .. SELECT
|
|
--let $error_codes = ER_LOCK_WAIT_TIMEOUT
|
|
INSERT DELAYED INTO t1 (a,b) SELECT 5, 'e';
|
|
--source check_errors.inc
|
|
|
|
--disconnect con0
|
|
--connection default
|
|
SELECT a,b FROM t1;
|
|
}
|
|
UNLOCK TABLES;
|
|
FLUSH TABLES;
|
|
SELECT a,b FROM t1;
|
|
|
|
# Cleanup
|
|
DROP TABLE t1;
|
|
|
|
--source cleanup_engine.inc
|
|
|