mirror of
https://github.com/MariaDB/server.git
synced 2025-08-07 00:04:31 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
122 lines
3.1 KiB
Plaintext
122 lines
3.1 KiB
Plaintext
#
|
|
# BUG#22516559 MYSQL INSTANCE STALLS WHEN SYNCING FTS INDEX
|
|
#
|
|
|
|
--source include/have_innodb.inc
|
|
--source include/have_debug.inc
|
|
--source include/have_debug_sync.inc
|
|
--source include/have_log_bin.inc
|
|
|
|
SET @old_log_output = @@global.log_output;
|
|
SET @old_slow_query_log = @@global.slow_query_log;
|
|
SET @old_general_log = @@global.general_log;
|
|
SET @old_long_query_time = @@global.long_query_time;
|
|
SET @old_debug = @@global.debug_dbug;
|
|
|
|
SET GLOBAL log_output = 'TABLE';
|
|
SET GLOBAL general_log = 1;
|
|
SET GLOBAL slow_query_log = 1;
|
|
SET GLOBAL long_query_time = 1;
|
|
|
|
connect (con1,localhost,root,,);
|
|
connect (con2,localhost,root,,);
|
|
connection default;
|
|
|
|
--echo # Case 1: Sync blocks DML(insert) on the same table.
|
|
CREATE TABLE t1 (
|
|
FTS_DOC_ID BIGINT UNSIGNED AUTO_INCREMENT NOT NULL PRIMARY KEY,
|
|
title VARCHAR(200),
|
|
FULLTEXT(title)
|
|
) ENGINE = InnoDB;
|
|
|
|
connection con1;
|
|
|
|
SET GLOBAL debug_dbug='+d,fts_instrument_sync_debug,fts_instrument_sync_sleep';
|
|
|
|
SET DEBUG_SYNC= 'fts_sync_begin SIGNAL begin WAIT_FOR continue';
|
|
|
|
send INSERT INTO t1(title) VALUES('mysql database');
|
|
|
|
connection con2;
|
|
|
|
SET DEBUG_SYNC= 'now WAIT_FOR begin';
|
|
|
|
send SELECT * FROM t1 WHERE MATCH(title) AGAINST('mysql database');
|
|
|
|
connection default;
|
|
SET DEBUG_SYNC= 'now SIGNAL continue';
|
|
|
|
connection con1;
|
|
--echo /* connection con1 */ INSERT INTO t1(title) VALUES('mysql database');
|
|
--reap
|
|
|
|
connection con2;
|
|
--echo /* connection con2 */ SELECT * FROM t1 WHERE MATCH(title) AGAINST('mysql database');
|
|
--reap
|
|
|
|
connection default;
|
|
-- echo # make con1 & con2 show up in mysql.slow_log
|
|
SELECT SLEEP(2);
|
|
-- echo # slow log results should only contain INSERT INTO t1.
|
|
SELECT sql_text FROM mysql.slow_log WHERE query_time >= '00:00:02';
|
|
|
|
SET GLOBAL debug_dbug = @old_debug;
|
|
TRUNCATE TABLE mysql.slow_log;
|
|
|
|
DROP TABLE t1;
|
|
|
|
--echo # Case 2: Sync blocks DML(insert) on other tables.
|
|
CREATE TABLE t1 (
|
|
FTS_DOC_ID BIGINT UNSIGNED AUTO_INCREMENT NOT NULL PRIMARY KEY,
|
|
title VARCHAR(200),
|
|
FULLTEXT(title)
|
|
) ENGINE = InnoDB;
|
|
|
|
CREATE TABLE t2(id INT);
|
|
|
|
connection con1;
|
|
|
|
SET GLOBAL debug_dbug='+d,fts_instrument_sync_request,fts_instrument_sync_sleep';
|
|
|
|
SET DEBUG_SYNC= 'fts_instrument_sync_request SIGNAL begin WAIT_FOR continue';
|
|
|
|
send INSERT INTO t1(title) VALUES('mysql database');
|
|
|
|
connection con2;
|
|
|
|
SET DEBUG_SYNC= 'now WAIT_FOR begin';
|
|
|
|
send INSERT INTO t2 VALUES(1);
|
|
|
|
connection default;
|
|
SET DEBUG_SYNC= 'now SIGNAL continue';
|
|
|
|
connection con1;
|
|
--echo /* connection con1 */ INSERT INTO t1(title) VALUES('mysql database');
|
|
--reap
|
|
|
|
connection con2;
|
|
--echo /* connection con2 */ INSERT INTO t2 VALUES(1);
|
|
--reap
|
|
|
|
connection default;
|
|
SET DEBUG_SYNC = 'RESET';
|
|
-- echo # make con1 & con2 show up in mysql.slow_log
|
|
SELECT SLEEP(2);
|
|
-- echo # slow log results should be empty here.
|
|
SELECT sql_text FROM mysql.slow_log WHERE query_time >= '00:00:02';
|
|
|
|
SET GLOBAL debug_dbug = @old_debug;
|
|
TRUNCATE TABLE mysql.slow_log;
|
|
|
|
DROP TABLE t1,t2;
|
|
|
|
disconnect con1;
|
|
disconnect con2;
|
|
|
|
-- echo # Restore slow log settings.
|
|
SET GLOBAL log_output = @old_log_output;
|
|
SET GLOBAL general_log = @old_general_log;
|
|
SET GLOBAL slow_query_log = @old_slow_query_log;
|
|
SET GLOBAL long_query_time = @old_long_query_time;
|