mirror of
https://github.com/MariaDB/server.git
synced 2025-08-05 13:16:09 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
32 lines
775 B
PHP
32 lines
775 B
PHP
#
|
|
# Test ANALYZE TABLE that does not flush table definition cache
|
|
# Arguments:
|
|
# $percona_nonflushing_analyze_table - table to test
|
|
#
|
|
|
|
--connect con1,localhost,root
|
|
|
|
SET DEBUG_SYNC="handler_rnd_next_end SIGNAL idx_scan_in_progress WAIT_FOR finish_scan";
|
|
|
|
send_eval SELECT * FROM $percona_nonflushing_analyze_table;
|
|
|
|
--connection default
|
|
|
|
SET DEBUG_SYNC="now WAIT_FOR idx_scan_in_progress";
|
|
|
|
set @tmp=@@use_stat_tables;
|
|
set use_stat_tables='preferably_for_queries';
|
|
eval ANALYZE TABLE $percona_nonflushing_analyze_table;
|
|
|
|
set use_stat_tables=@tmp;
|
|
# With the bug fixed this should not block
|
|
eval SELECT * FROM $percona_nonflushing_analyze_table;
|
|
|
|
SET DEBUG_SYNC="now SIGNAL finish_scan";
|
|
|
|
--connection con1
|
|
reap;
|
|
--disconnect con1
|
|
--connection default
|
|
SET DEBUG_SYNC='reset';
|