mirror of
https://github.com/MariaDB/server.git
synced 2025-08-09 22:24:09 +03:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
55 lines
1.9 KiB
Plaintext
55 lines
1.9 KiB
Plaintext
###############################################################################
|
|
# Bug#17942050:KILL OF TRUNCATE TABLE WILL LEAD TO BINARY LOG WRITTEN WHILE
|
|
# ROWS REMAINS
|
|
#
|
|
# Problem:
|
|
# ========
|
|
# When truncate table fails while using transactional based engines even
|
|
# though the operation errors out we still continue and log it to binlog.
|
|
# Because of this master has data but the truncate will be written to binary
|
|
# log which will cause inconsistency.
|
|
#
|
|
# Test:
|
|
# =====
|
|
# Make master to wait in "open_table" call during the execution of truncate
|
|
# table command and kill the truncate table from other connection. This causes
|
|
# open table to return an error saying truncate failed during open table. This
|
|
# statement should not be binlogged.
|
|
###############################################################################
|
|
--source include/have_innodb.inc
|
|
--source include/have_debug_sync.inc
|
|
--source include/have_binlog_format_statement.inc
|
|
RESET MASTER;
|
|
--connection default
|
|
CREATE TABLE t1(id INT AUTO_INCREMENT PRIMARY KEY, a INT, b INT) ENGINE=INNODB;
|
|
INSERT INTO t1(a, b) VALUES(1,2),(2,4),(3,6),(4,8),(5,10);
|
|
SET DEBUG_SYNC = "open_and_process_table signal truncate_before_lock wait_for forever";
|
|
--send TRUNCATE t1
|
|
|
|
connect(con1,localhost,root,,);
|
|
SET DEBUG_SYNC = "now wait_for truncate_before_lock";
|
|
# Wait for one connection to reach open_and_process_table.
|
|
--let $show_statement= SHOW PROCESSLIST
|
|
--let $field= State
|
|
--let $condition= 'debug sync point: open_and_process_table';
|
|
--source include/wait_show_condition.inc
|
|
|
|
SELECT ((@id := id) - id) FROM information_schema.processlist WHERE processlist.info LIKE '%TRUNCATE t1%' AND state LIKE '%open_and_process_table%';
|
|
# Test killing from mysql server
|
|
KILL QUERY @id;
|
|
|
|
connection default;
|
|
--ERROR ER_QUERY_INTERRUPTED
|
|
--reap
|
|
|
|
connection con1;
|
|
--source include/show_binlog_events.inc
|
|
|
|
disconnect con1;
|
|
connection default;
|
|
|
|
SELECT * FROM t1;
|
|
|
|
DROP TABLE t1;
|
|
SET DEBUG_SYNC= 'RESET';
|