mirror of
https://github.com/MariaDB/server.git
synced 2026-10-23 18:49:29 +03:00
ee17c7934c
wsrep_sync_wait is a per-statement-type bitmask (READ, UPDATE/DELETE, INSERT/REPLACE, SHOW) that forces a causal wait - block until this node has applied every write already certified cluster-wide - before executing a matching statement. wsrep_must_sync_wait() unconditionally skipped this wait whenever the session was already inside a multi-statement transaction, regardless of which bit was configured for the statement at hand. Once BEGIN (or, via autocommit=0, the first statement) had opened a transaction, every later statement in it was exempt from its own causal wait - so writes could run against a view no fresher than whatever BEGIN itself happened to check, which is only the READ bit, regardless of the actual configured mask. Fix: only skip the wait once this transaction has generated its first write (wsrep_has_changes(thd)). Every statement up to and including that first write is still safe to wait for - nothing of this transaction's is locked yet when the pre-statement check runs - which closes the gap above. Nothing after the first write re-waits, matching the original behaviour for the rest of the transaction: once this session may be holding row locks, a fresh causal wait risks a self-deadlock against its own local applier (which can be blocked needing one of those same locks to apply a write-set this wait is waiting for, with nothing to resolve it but the wait's own timeout). A second, independent defect surfaced once in-transaction waits could time out at all: wsrep::client_state::after_command_after_result() only clears a pending wsrep error once the transaction is no longer active - correct for a genuinely doomed BF-aborted transaction, but a causal-wait timeout is a pre-check failure that touches nothing, so this left every later statement in the same transaction, ROLLBACK included, failing with the same stale error. wsrep_sync_wait() now resets the error immediately after reporting it for the one statement that actually hit it, scoped to this failure path only - genuine BF-abort/deadlock errors elsewhere keep their correct sticky-until- rollback behaviour. Tests: galera_MDEV-38999.test covers the original bitmask gap across both explicit BEGIN and autocommit=0 transactions, and a repeated-read scenario proving a satisfied bit isn't cached across statements. galera_MDEV-38999_locks.test and galera_MDEV-38999_autocommit.test exercise the self-deadlock risk directly: a transaction already holding a row lock the paused applier needs must still return promptly once the applier is released, not block for the full repl.causal_read_timeout. Assisted-by Claude AI
This directory contains test suites for the MariaDB server. To run currently existing test cases, execute ./mysql-test-run in this directory. Some tests are known to fail on some platforms or be otherwise unreliable. In the file collections/smoke_test there is a list of tests that are expected to be stable. In general you do not have to have to do "make install", and you can have a co-existing MariaDB installation, the tests will not conflict with it. To run the tests in a source directory, you must do "make" first. In Red Hat distributions, you should run the script as user "mysql". The user is created with nologin shell, so the best bet is something like # su - # cd /usr/share/mysql-test # su -s /bin/bash mysql -c ./mysql-test-run This will use the installed MariaDB executables, but will run a private copy of the server process (using data files within /usr/share/mysql-test), so you need not start the mysqld service beforehand. You can omit --skip-test-list option if you want to check whether the listed failures occur for you. To clean up afterwards, remove the created "var" subdirectory, e.g. # su -s /bin/bash - mysql -c "rm -rf /usr/share/mysql-test/var" If tests fail on your system, please read the following manual section for instructions on how to report the problem: https://mariadb.com/docs/general-resources/community/community/bug-tracking/reporting-bugs If you want to use an already running MySQL server for specific tests, use the --extern option to mysql-test-run. Please note that in this mode, you are expected to provide names of the tests to run. For example, here is the command to run the "alias" and "analyze" tests with an external server: # mysql-test-run --extern socket=/tmp/mysql.sock alias analyze To match your setup, you might need to provide other relevant options. With no test names on the command line, mysql-test-run will attempt to execute the default set of tests, which will certainly fail, because many tests cannot run with an external server (they need to control the options with which the server is started, restart the server during execution, etc.) You can create your own test cases. To create a test case, create a new file in the main subdirectory using a text editor. The file should have a .test extension. For example: # xemacs t/test_case_name.test In the file, put a set of SQL statements that create some tables, load test data, and run some queries to manipulate it. Your test should begin by dropping the tables you are going to create and end by dropping them again. This ensures that you can run the test over and over again. If you are using mysqltest commands in your test case, you should create the result file as follows: # mysql-test-run --record test_case_name or # mysqltest --record < t/test_case_name.test If you only have a simple test case consisting of SQL statements and comments, you can create the result file in one of the following ways: # mysql-test-run --record test_case_name # mysql test < t/test_case_name.test > r/test_case_name.result # mysqltest --record --database test --result-file=r/test_case_name.result < t/test_case_name.test When this is done, take a look at r/test_case_name.result. If the result is incorrect, you have found a bug. In this case, you should edit the test result to the correct results so that we can verify that the bug is corrected in future releases. If you want to submit your test case you can send it to developers@lists.mariadb.org or attach it to a bug report on http://mariadb.org/jira/. If the test case is really big or if it contains 'not public' data, then put your .test file and .result file(s) into a tar.gz archive, add a README that explains the problem, ftp the archive to ftp://ftp.mariadb.org/private and submit a report to https://mariadb.org/jira about it. The latest information about mysql-test-run can be found at: https://mariadb.com/docs/server/clients-and-utilities/testing-tools/mariadb-test If you want to create .rdiff files, check https://mariadb.com/docs/server/clients-and-utilities/testing-tools/mariadb-test/mariadb-test-auxiliary-files