database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-18 23:03:28 +03:00
Code Activity

Bug#43748: crash when non-super user tries to kill the replication threads

Browse Source 
Test was flakey on some machines and showed spurious
reds for races.

New-and-improved test makes do with fewer statements,
no mysqltest-variables, and no backticks. Should hope-
fully be more robust. Heck, it's debatable whether we
should have a test for this, anyway.

mysql-test/suite/rpl/r/rpl_temporary.result:
  streamlined
mysql-test/suite/rpl/t/rpl_temporary.test:
  streamlined
This commit is contained in:
Tatiana A. Nurnberg
2009-03-27 12:20:37 +01:00
parent fb8ac41a3b
commit ffd9792ca5
2 changed files with 22 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
mysql-test/suite/rpl/r/rpl_temporary.result
View File

@ -108,13 +108,16 @@ select * from t1;
a a
1 1
drop table t1; drop table t1;
Bug#43748 -- Bug#43748
make a non-privileged user on slave. -- make a user on the slave that can list but not kill system threads.
FLUSH PRIVILEGES; FLUSH PRIVILEGES;
GRANT USAGE ON *.* TO user43748@127.0.0.1 IDENTIFIED BY 'meow'; GRANT USAGE ON *.* TO user43748@127.0.0.1 IDENTIFIED BY 'meow';
try to KILL system-thread as non-privileged user. GRANT PROCESS ON *.* TO user43748@127.0.0.1;
KILL `select id from information_schema.processlist where command='Binlog Dump'`; -- try to KILL system-thread as that non-privileged user (on slave).
ERROR HY000: You are not owner of thread `select id from information_schema.processlist where command='Binlog Dump'` SELECT id INTO @id FROM information_schema.processlist WHERE user='system user' LIMIT 1;
throw out test-user on slave. KILL @id;
Got one of the listed errors
-- throw out test-user on slave.
DROP USER user43748@127.0.0.1; DROP USER user43748@127.0.0.1;
done. back to master. -- done. back to master.
End of 5.1 tests

22
mysql-test/suite/rpl/t/rpl_temporary.test
View File

@ -228,36 +228,34 @@ source include/delete_anonymous_users.inc;
# Bug#43748: crash when non-super user tries to kill the replication threads # Bug#43748: crash when non-super user tries to kill the replication threads
# #
--echo Bug#43748 --echo -- Bug#43748
--echo -- make a user on the slave that can list but not kill system threads.
connection slave; connection slave;
--echo make a non-privileged user on slave.
FLUSH PRIVILEGES; FLUSH PRIVILEGES;
GRANT USAGE ON *.* TO user43748@127.0.0.1 IDENTIFIED BY 'meow'; GRANT USAGE ON *.* TO user43748@127.0.0.1 IDENTIFIED BY 'meow';
GRANT PROCESS ON *.* TO user43748@127.0.0.1;
let $id = `SELECT id FROM information_schema.processlist WHERE user='system user' LIMIT 1`; --echo -- try to KILL system-thread as that non-privileged user (on slave).
connect (cont43748,127.0.0.1,user43748,meow,test,$SLAVE_MYPORT,); connect (cont43748,127.0.0.1,user43748,meow,test,$SLAVE_MYPORT,);
connection cont43748; connection cont43748;
--echo try to KILL system-thread as non-privileged user. SELECT id INTO @id FROM information_schema.processlist WHERE user='system user' LIMIT 1;
--replace_result $id "`select id from information_schema.processlist where command='Binlog Dump'`" --error ER_KILL_DENIED_ERROR,ER_NO_SUCH_THREAD
--error ER_KILL_DENIED_ERROR KILL @id;
eval KILL $id;
disconnect cont43748; disconnect cont43748;
--echo -- throw out test-user on slave.
connection slave; connection slave;
--echo throw out test-user on slave.
DROP USER user43748@127.0.0.1; DROP USER user43748@127.0.0.1;
--echo -- done. back to master.
connection master; connection master;
--echo done. back to master.
# End of tests --echo End of 5.1 tests