database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

Fixed issues found by valgrind

Browse Source 
- mysqltest didn't free read_command_buf
- wait_for_slave_param did write different things to the log if valgrind
  was used.
- Table open cache should not write the initial variable value as it
  can depend on the configuration or if valgrind is used
- A variable in GetResult was used uninitalized
This commit is contained in:
Monty
2019-08-12 15:40:57 +03:00
parent 3b234104ae
commit fe8181aca1
6 changed files with 12 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
mysql-test/suite/sys_vars/t/table_open_cache_basic.test
View File

@ -4,8 +4,8 @@
# Scope: GLOBAL #
# Access Type: Dynamic #
# Data Type: numeric #
# Default Value: 400 #
# Range: 64-524288 #
# Default Value: 400 #
# Range: 64-524288 #
# #
# #
# Creation Date: 2008-02-13 #
@ -35,18 +35,6 @@
##########################################################################
SET @start_value = @@global.table_open_cache ;
SELECT @start_value;
--echo '#--------------------FN_DYNVARS_001_01------------------------#'
########################################################################
# Display the DEFAULT value of table_open_cache #
########################################################################
SET @@global.table_open_cache = 99;
SET @@global.table_open_cache = DeFAULT;
SELECT @@global.table_open_cache;
--echo '#---------------------FN_DYNVARS_001_02-------------------------#'
###############################################
@ -54,7 +42,7 @@ SELECT @@global.table_open_cache;
###############################################
SET @@global.table_open_cache = Default;
SELECT @@global.table_open_cache = 400;
SELECT @@global.table_open_cache > 0;
--echo '#--------------------FN_DYNVARS_001_03------------------------#'
########################################################################
@ -152,8 +140,6 @@ SELECT @@table_open_cache = @@global.table_open_cache ;
--Error ER_GLOBAL_VARIABLE
SET table_open_cache = 8;
--Error ER_PARSE_ERROR
SET global.table_open_cache = 10;
--Error ER_UNKNOWN_TABLE
SELECT global.table_open_cache ;
--Error ER_BAD_FIELD_ERROR
@ -165,10 +151,7 @@ SELECT table_open_cache = @@session.table_open_cache ;
##############################
SET @@global.table_open_cache = @start_value;
SELECT @@global.table_open_cache ;
##################################################################
# END OF table_open_cache TESTS #
##################################################################