database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

A patch for Bug#34820: log_output can be set to illegal value.

Browse Source 
We have "set" variables, which can accept empty values
(like sql_mode), and which can not (like log_output). The problem
was that the code does not distinguish them and allow empty
values for every set variable.

The fix is to introduce an attribute of a set variable telling
whether it can accept empty values.


mysql-test/r/variables.result:
  Update result file.
mysql-test/t/variables.test:
  A test case for Bug#34820: log_output can be set to illegal value.
sql/set_var.cc:
  Don't allow empty values if it is prohibitted.
sql/set_var.h:
  Add a flag (m_allow_empty_value) telling if an empty value is
  acceptable for this variable.
This commit is contained in:
unknown
2008-03-28 18:10:04 +03:00
parent 1abfb6e040
commit fba9e7c878
4 changed files with 63 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
mysql-test/t/variables.test
View File

@ -778,3 +778,20 @@ set global thread_cache_size =@my_thread_cache_size;
--replace_column 2 #
show global variables where Variable_name='table_definition_cache' or
Variable_name='table_lock_wait_timeout';
###########################################################################
--echo
--echo # --
--echo # -- Bug#34820: log_output can be set to illegal value.
--echo # --
--error ER_WRONG_VALUE_FOR_VAR
SET GLOBAL log_output = '';
--error ER_WRONG_VALUE_FOR_VAR
SET GLOBAL log_output = 0;
--echo
--echo # -- End of Bug#34820.