database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

Removing the binlog-show-xid option as it was only a temporary solution until we have replace-regex which we have now.

Browse Source 
That option was used to suppress the XID from the output of SHOW BINLOG EVENTS (to create a repeatable testsuite),
was available only in debug builds, and was explicitely marked as "may be removed in future versions" in mysqld --help.
Idea of the removal approved by the replication team.


mysql-test/extra/binlog_tests/binlog.test:
  use replace-regex to remove xid
mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test:
  use replace-regex to remove xid
mysql-test/mysql-test-run.pl:
  option removed
mysql-test/mysql-test-run.sh:
  option removed
sql/log_event.cc:
  no more need to hide XID in tests output as we have replace-regex
sql/log_event.h:
  no more need to hide XID in tests output as we have replace-regex
sql/mysqld.cc:
  no more need to hide XID in tests output as we have replace-regex
This commit is contained in:
unknown
2006-05-17 22:16:51 +02:00
parent 9c7800f600
commit fb1ed3900b
7 changed files with 17 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mysql-test/mysql-test-run.pl
View File

@ -2597,7 +2597,6 @@ sub mysqld_arguments ($$$$$$) {
mtr_add_arg($args, "%s--character-sets-dir=%s", $prefix, $path_charsetsdir);
mtr_add_arg($args, "%s--core", $prefix);
mtr_add_arg($args, "%s--log-bin-trust-function-creators", $prefix);
mtr_add_arg($args, "%s--loose-binlog-show-xid=0", $prefix);
mtr_add_arg($args, "%s--default-character-set=latin1", $prefix);
mtr_add_arg($args, "%s--language=%s", $prefix, $path_language);
mtr_add_arg($args, "%s--tmpdir=$opt_tmpdir", $prefix);
@ -2743,7 +2742,6 @@ sub mysqld_arguments ($$$$$$) {
mtr_add_arg($args, "%s--sort_buffer=256K", $prefix);
mtr_add_arg($args, "%s--max_heap_table_size=1M", $prefix);
mtr_add_arg($args, "%s--log-bin-trust-function-creators", $prefix);
mtr_add_arg($args, "%s--loose-binlog-show-xid=0", $prefix);
if ( $opt_ssl_supported )
{