database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

Fix for bug #10004 (Decimal operation crashes server)

Browse Source 
mysql-test/r/type_newdecimal.result:
  test result fixed
mysql-test/t/type_newdecimal.test:
  test case added
strings/decimal.c:
  old code didn't work when both decimals had zero before the decimal point
This commit is contained in:
unknown
2005-05-06 20:06:25 +05:00
parent 0baed276c3
commit f98913819b
3 changed files with 20 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
mysql-test/r/type_newdecimal.result
View File

@ -846,3 +846,6 @@ set sql_mode='';
select 0/0; select 0/0;
0/0 0/0
NULL NULL
select 0.190287977636363637 + 0.040372670 * 0 - 0;
0.190287977636363637 + 0.040372670 * 0 - 0
0.190287977636363637

5
mysql-test/t/type_newdecimal.test
View File

@ -876,3 +876,8 @@ select 10.3330000000000/12.34500000;
set sql_mode=''; set sql_mode='';
select 0/0; select 0/0;
#
# Bug #10004
#
select 0.190287977636363637 + 0.040372670 * 0 - 0;

20
strings/decimal.c
View File

@ -1703,19 +1703,23 @@ static int do_sub(decimal_t *from1, decimal_t *from2, decimal_t *to)
carry=1; carry=1;
else if (intg2 == intg1) else if (intg2 == intg1)
{ {
while (unlikely(stop1[frac1-1] == 0)) dec1 *end1= stop1 + (frac1 - 1);
frac1--; dec1 *end2= stop2 + (frac2 - 1);
while (unlikely(stop2[frac2-1] == 0)) while (unlikely((buf1 <= end1) && (*end1 == 0)))
frac2--; end1--;
while (buf1 < stop1+frac1 && buf2 < stop2+frac2 && *buf1 == *buf2) while (unlikely((buf2 <= end2) && (*end2 == 0)))
end2--;
frac1= (end1 - stop1) + 1;
frac2= (end2 - stop2) + 1;
while (buf1 <=end1 && buf2 <= end2 && *buf1 == *buf2)
buf1++, buf2++; buf1++, buf2++;
if (buf1 < stop1+frac1) if (buf1 <= end1)
if (buf2 < stop2+frac2) if (buf2 <= end2)
carry= *buf2 > *buf1; carry= *buf2 > *buf1;
else else
carry= 0; carry= 0;
else else
if (buf2 < stop2+frac2) if (buf2 <= end2)
carry=1; carry=1;
else /* short-circuit everything: from1 == from2 */ else /* short-circuit everything: from1 == from2 */
{ {