From f66ef6a05d151a884acbc861dbbe0288232317cd Mon Sep 17 00:00:00 2001 From: Eric Herman Date: Wed, 26 Aug 2015 11:50:47 +0200 Subject: [PATCH] Add lru evict count for the idle loop (xtradb) --- storage/xtradb/include/srv0mon.h | 3 ++- storage/xtradb/srv/srv0mon.cc | 11 ++++++++--- storage/xtradb/srv/srv0srv.cc | 7 +++++-- 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/storage/xtradb/include/srv0mon.h b/storage/xtradb/include/srv0mon.h index 249e7b2c41e..37d14734c71 100644 --- a/storage/xtradb/include/srv0mon.h +++ b/storage/xtradb/include/srv0mon.h @@ -379,7 +379,8 @@ enum monitor_id_t { MONITOR_SRV_MEM_VALIDATE_MICROSECOND, MONITOR_SRV_PURGE_MICROSECOND, MONITOR_SRV_DICT_LRU_MICROSECOND, - MONITOR_SRV_DICT_LRU_EVICT_COUNT, + MONITOR_SRV_DICT_LRU_EVICT_COUNT_ACTIVE, + MONITOR_SRV_DICT_LRU_EVICT_COUNT_IDLE, MONITOR_SRV_CHECKPOINT_MICROSECOND, MONITOR_OVLD_SRV_DBLWR_WRITES, MONITOR_OVLD_SRV_DBLWR_PAGES_WRITTEN, diff --git a/storage/xtradb/srv/srv0mon.cc b/storage/xtradb/srv/srv0mon.cc index 4a260d8100f..0b2e29e5f68 100644 --- a/storage/xtradb/srv/srv0mon.cc +++ b/storage/xtradb/srv/srv0mon.cc @@ -1196,10 +1196,15 @@ static monitor_info_t innodb_counter_info[] = MONITOR_NONE, MONITOR_DEFAULT_START, MONITOR_SRV_DICT_LRU_MICROSECOND}, - {"innodb_dict_lru_count", "server", - "Number of tables evicted from DICT LRU list", + {"innodb_dict_lru_count_active", "server", + "Number of tables evicted from DICT LRU list in the active loop", MONITOR_NONE, - MONITOR_DEFAULT_START, MONITOR_SRV_DICT_LRU_EVICT_COUNT}, + MONITOR_DEFAULT_START, MONITOR_SRV_DICT_LRU_EVICT_COUNT_ACTIVE}, + + {"innodb_dict_lru_count_idle", "server", + "Number of tables evicted from DICT LRU list in the idle loop", + MONITOR_NONE, + MONITOR_DEFAULT_START, MONITOR_SRV_DICT_LRU_EVICT_COUNT_IDLE}, {"innodb_checkpoint_usec", "server", "Time (in microseconds) spent by master thread to do checkpoint", diff --git a/storage/xtradb/srv/srv0srv.cc b/storage/xtradb/srv/srv0srv.cc index 12bd82f9158..abe47e91339 100644 --- a/storage/xtradb/srv/srv0srv.cc +++ b/storage/xtradb/srv/srv0srv.cc @@ -2944,7 +2944,7 @@ srv_master_do_active_tasks(void) srv_main_thread_op_info = "enforcing dict cache limit"; n_evicted = srv_master_evict_from_table_cache(50); MONITOR_INC_VALUE( - MONITOR_SRV_DICT_LRU_EVICT_COUNT, n_evicted); + MONITOR_SRV_DICT_LRU_EVICT_COUNT_ACTIVE, n_evicted); MONITOR_INC_TIME_IN_MICRO_SECS( MONITOR_SRV_DICT_LRU_MICROSECOND, counter_time); } @@ -2976,6 +2976,7 @@ srv_master_do_idle_tasks(void) /*==========================*/ { ullint counter_time; + ulint n_evicted = 0; ++srv_main_idle_loops; @@ -3013,7 +3014,9 @@ srv_master_do_idle_tasks(void) } srv_main_thread_op_info = "enforcing dict cache limit"; - srv_master_evict_from_table_cache(100); + n_evicted = srv_master_evict_from_table_cache(100); + MONITOR_INC_VALUE( + MONITOR_SRV_DICT_LRU_EVICT_COUNT_IDLE, n_evicted); MONITOR_INC_TIME_IN_MICRO_SECS( MONITOR_SRV_DICT_LRU_MICROSECOND, counter_time);