mirror of
https://github.com/MariaDB/server.git
synced 2025-07-27 18:02:13 +03:00
API change: mysql_shutdown() now needs a 2nd parameter, the shutdown level.
Server will however still accept shutdown without specified level; so that old mysqladmin can still shut server down. I would like your comments on the names of shutdown level which I chose. You are welcome to propose better names. Please however check WL#709 before. Reason for the names I propose is to be accurate, thus leaving possibility for other levels which we may imagine in the future; that's why I have rejected names like "fast", "smart", "graceful" so far. My position is that WAIT_ALL_BUFFERS or WAIT_CRITICAL_BUFFERS say what the shutdown does, whereas for "smart", "fast" you need to remember what it does. This should be pushed in 4.1.3 but only after your comments.
This commit is contained in:
@ -1285,10 +1285,13 @@ mysql_drop_db(MYSQL *mysql, const char *db)
|
||||
|
||||
|
||||
int STDCALL
|
||||
mysql_shutdown(MYSQL *mysql)
|
||||
mysql_shutdown(MYSQL *mysql, enum enum_shutdown_level shutdown_level)
|
||||
{
|
||||
uchar level[1];
|
||||
level[0]= (uchar) shutdown_level;
|
||||
DBUG_ENTER("mysql_shutdown");
|
||||
DBUG_RETURN(simple_command(mysql,COM_SHUTDOWN,0,0,0));
|
||||
DBUG_RETURN(simple_command(mysql, COM_SHUTDOWN,
|
||||
&level, 1, 0));
|
||||
}
|
||||
|
||||
|
||||
|
Reference in New Issue
Block a user