database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-30710 Incorrect operator when comparing large unsigned integers.

Browse Source 
When constructing a SEL_TREE, an unsigned integer greater than
its signed equivalent caused an incorrect comparison operator to
be chosen.
This commit is contained in:
Rex
2023-07-19 15:59:33 +11:00
parent 1a5c4c2d9b
commit f17a865c39
3 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
mysql-test/main/type_int.result
View File

@@ -1675,5 +1675,16 @@ SELECT DISTINCT 1 FROM t1 GROUP BY 0 >> NULL WITH ROLLUP;
1 1
DROP TABLE t1; DROP TABLE t1;
# #
# MDEV-30710 Incorrect operator when comparing large unsigned integers.
#
create table t1(c0 tinyint unique);
insert into t1 values (127);
insert into t1 values (-128);
select * from t1 where 18446744073700599371 > c0;
c0
-128
127
drop table t1;
#
# End of 10.5 tests # End of 10.5 tests
# #

9
mysql-test/main/type_int.test
View File

@@ -554,6 +554,15 @@ INSERT INTO t1 VALUES (1),(2);
SELECT DISTINCT 1 FROM t1 GROUP BY 0 >> NULL WITH ROLLUP; SELECT DISTINCT 1 FROM t1 GROUP BY 0 >> NULL WITH ROLLUP;
DROP TABLE t1; DROP TABLE t1;
--echo #
--echo # MDEV-30710 Incorrect operator when comparing large unsigned integers.
--echo #
create table t1(c0 tinyint unique);
insert into t1 values (127);
insert into t1 values (-128);
select * from t1 where 18446744073700599371 > c0;
drop table t1;
--echo # --echo #
--echo # End of 10.5 tests --echo # End of 10.5 tests

3
sql/opt_range.cc
View File

@@ -8995,7 +8995,8 @@ SEL_ARG *Field::stored_field_make_mm_leaf_bounded_int(RANGE_OPT_PARAM *param,
DBUG_RETURN(new (param->mem_root) SEL_ARG_IMPOSSIBLE(this)); DBUG_RETURN(new (param->mem_root) SEL_ARG_IMPOSSIBLE(this));
longlong item_val= value->val_int(); longlong item_val= value->val_int();
if (op == SCALAR_CMP_LT && item_val > 0) if (op == SCALAR_CMP_LT && ((item_val > 0)
|| (value->unsigned_flag && (ulonglong)item_val > 0 )))
op= SCALAR_CMP_LE; // e.g. rewrite (tinyint < 200) to (tinyint <= 127) op= SCALAR_CMP_LE; // e.g. rewrite (tinyint < 200) to (tinyint <= 127)
else if (op == SCALAR_CMP_GT && !unsigned_field && else if (op == SCALAR_CMP_GT && !unsigned_field &&
!value->unsigned_flag && item_val < 0) !value->unsigned_flag && item_val < 0)