database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-28433 : Server crashes when wsrep_sst_donor and wsrep_cluster_address set to NULL

Browse Source 
Do not allow setting wsrep_sst_donor as NULL as it is
incorrect value. User can use value '' (default) that represents
same as NULL. Setting wsrep_cluster_address to NULL is
already handled correctly.

Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>
This commit is contained in:
Jan Lindström
2023-05-03 08:29:38 +03:00
committed by Julius Goryavsky
parent 7d55eb00f3
commit f102b595e8
5 changed files with 81 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
mysql-test/suite/sys_vars/r/wsrep_sst_donor_basic.result
View File

@@ -33,17 +33,22 @@ SET @@global.wsrep_sst_donor=default;
SELECT @@global.wsrep_sst_donor;
@@global.wsrep_sst_donor
SET @@global.wsrep_sst_donor=NULL;
SET @@global.wsrep_sst_donor='';
SELECT @@global.wsrep_sst_donor;
@@global.wsrep_sst_donor
NULL
# invalid values
SET @@global.wsrep_sst_donor=1;
ERROR 42000: Incorrect argument type to variable 'wsrep_sst_donor'
SELECT @@global.wsrep_sst_donor;
@@global.wsrep_sst_donor
NULL
SET @@global.wsrep_sst_donor=NULL;
ERROR 42000: Variable 'wsrep_sst_donor' can't be set to the value of 'NULL'
SELECT @@global.wsrep_sst_donor;
@@global.wsrep_sst_donor
# restore the initial value
SET @@global.wsrep_sst_donor = @wsrep_sst_donor_global_saved;

5
mysql-test/suite/sys_vars/t/wsrep_sst_donor_basic.test
View File

@@ -27,7 +27,7 @@ SET @@global.wsrep_sst_donor='hyphenated-donor-name';
SELECT @@global.wsrep_sst_donor;
SET @@global.wsrep_sst_donor=default;
SELECT @@global.wsrep_sst_donor;
SET @@global.wsrep_sst_donor=NULL;
SET @@global.wsrep_sst_donor='';
SELECT @@global.wsrep_sst_donor;
--echo
@@ -35,6 +35,9 @@ SELECT @@global.wsrep_sst_donor;
--error ER_WRONG_TYPE_FOR_VAR
SET @@global.wsrep_sst_donor=1;
SELECT @@global.wsrep_sst_donor;
--error ER_WRONG_VALUE_FOR_VAR
SET @@global.wsrep_sst_donor=NULL;
SELECT @@global.wsrep_sst_donor;
--echo
--echo # restore the initial value