database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

Simplified away CONNECT::real_id

Browse Source 
It was wrong anyway, as it may not get updated by the time created thread
reads it. And it was 0 for cached threads.

Part of MDEV-19515 - Improve connect speed
This commit is contained in:
Sergey Vojtovich
2019-05-12 11:15:53 +04:00
parent 7192d7b700
commit efb61c12a9
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
sql/mysqld.cc
View File

@ -6208,8 +6208,9 @@ void create_thread_to_handle_connection(CONNECT *connect)
DBUG_PRINT("info",(("creating thread %lu"), (ulong) connect->thread_id)); DBUG_PRINT("info",(("creating thread %lu"), (ulong) connect->thread_id));
connect->prior_thr_create_utime= microsecond_interval_timer(); connect->prior_thr_create_utime= microsecond_interval_timer();
pthread_t tmp;
if (auto error= mysql_thread_create(key_thread_one_connection, if (auto error= mysql_thread_create(key_thread_one_connection,
&connect->real_id, &connection_attrib, &tmp, &connection_attrib,
handle_one_connection, (void*) connect)) handle_one_connection, (void*) connect))
{ {
char error_message_buff[MYSQL_ERRMSG_SIZE]; char error_message_buff[MYSQL_ERRMSG_SIZE];

2
sql/sql_connect.cc
View File

@ -1522,6 +1522,6 @@ THD *CONNECT::create_thd(THD *thd)
my_localhost : 0; my_localhost : 0;
thd->scheduler= scheduler; thd->scheduler= scheduler;
thd->real_id= real_id; thd->real_id= pthread_self(); /* Duplicates THD::store_globals() setting. */
DBUG_RETURN(thd); DBUG_RETURN(thd);
} }

3
sql/sql_connect.h
View File

@ -34,14 +34,13 @@ public:
Vio *vio; /* Copied to THD with my_net_init() */ Vio *vio; /* Copied to THD with my_net_init() */
scheduler_functions *scheduler; scheduler_functions *scheduler;
my_thread_id thread_id; my_thread_id thread_id;
pthread_t real_id;
/* Own variables */ /* Own variables */
bool thread_count_incremented; bool thread_count_incremented;
ulonglong prior_thr_create_utime; ulonglong prior_thr_create_utime;
CONNECT() CONNECT()
:vio(0), scheduler(thread_scheduler), thread_id(0), real_id(0), :vio(0), scheduler(thread_scheduler), thread_id(0),
thread_count_incremented(0), prior_thr_create_utime(0) thread_count_incremented(0), prior_thr_create_utime(0)
{ {
}; };