database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-14871 Server crashes in fill_record / fill_record_n_invoke_before_triggers upon inserting into versioned table with trigger

Browse Source
This commit is contained in:
Eugene Kosov
2018-01-10 12:30:27 +03:00
committed by Aleksey Midenkov
parent c59c1a0736
commit eedab70c1c
3 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mysql-test/suite/versioning/r/insert.result
View File

@ -358,4 +358,10 @@ a
select * from t1 for system_time as of sysdate(6); select * from t1 for system_time as of sysdate(6);
a a
1 1
#
# MDEV-14871 Server crashes in fill_record / fill_record_n_invoke_before_triggers upon inserting into versioned table with trigger
#
create or replace table t1 (pk int primary key) with system versioning;
create trigger tr before insert on t1 for each row select 1 into @a;
insert into t1 values (1),(2);
drop table t1; drop table t1;

8
mysql-test/suite/versioning/t/insert.test
View File

@ -251,4 +251,12 @@ create table t1 (a int) with system versioning;
insert t1 values (1); insert t1 values (1);
select * from t1 for system_time as of now(6); select * from t1 for system_time as of now(6);
select * from t1 for system_time as of sysdate(6); select * from t1 for system_time as of sysdate(6);
--echo #
--echo # MDEV-14871 Server crashes in fill_record / fill_record_n_invoke_before_triggers upon inserting into versioned table with trigger
--echo #
create or replace table t1 (pk int primary key) with system versioning;
create trigger tr before insert on t1 for each row select 1 into @a;
insert into t1 values (1),(2);
drop table t1; drop table t1;

2
sql/sql_trigger.cc
View File

@ -1228,7 +1228,7 @@ bool Table_triggers_list::prepare_record_accessors(TABLE *table)
uchar null_bit= 1; uchar null_bit= 1;
for (fld= table->field, trg_fld= record0_field; *fld; fld++, trg_fld++) for (fld= table->field, trg_fld= record0_field; *fld; fld++, trg_fld++)
{ {
if (!(*fld)->null_ptr && !(*fld)->vcol_info) if (!(*fld)->null_ptr && !(*fld)->vcol_info && !(*fld)->vers_sys_field())
{ {
Field *f; Field *f;
if (!(f= *trg_fld= (*fld)->make_new_field(&table->mem_root, table, if (!(f= *trg_fld= (*fld)->make_new_field(&table->mem_root, table,