database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

clarify CR_OK_HANDSHAKE_COMPLETE

Browse Source 
it's for client auth plugins only, server auth plugin should never
return it, because they cannot send a correct OK packet.
(OK packet is quite complex and carries a lot of information that
only the server knows)
This commit is contained in:
Sergei Golubchik
2023-08-21 11:08:37 +02:00
parent 75bfb4b8a3
commit ec5403ffb3
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/mysql/plugin_auth_common.h
View File

@ -85,6 +85,8 @@
authentication protocol is not known in advance, and the client plugin authentication protocol is not known in advance, and the client plugin
needs to read one packet more to determine if the authentication is finished needs to read one packet more to determine if the authentication is finished
or not. or not.
Server plugins should not return this value.
*/ */
#define CR_OK_HANDSHAKE_COMPLETE -2 #define CR_OK_HANDSHAKE_COMPLETE -2

5
sql/sql_acl.cc
View File

@ -14844,10 +14844,7 @@ bool acl_authenticate(THD *thd, uint com_change_user_pkt_len)
sctx->external_user= my_strdup(key_memory_MPVIO_EXT_auth_info, sctx->external_user= my_strdup(key_memory_MPVIO_EXT_auth_info,
mpvio.auth_info.external_user, MYF(0)); mpvio.auth_info.external_user, MYF(0));
if (res == CR_OK_HANDSHAKE_COMPLETE) my_ok(thd);
thd->get_stmt_da()->disable_status();
else
my_ok(thd);
PSI_CALL_set_thread_account PSI_CALL_set_thread_account
(thd->main_security_ctx.user, static_cast<uint>(strlen(thd->main_security_ctx.user)), (thd->main_security_ctx.user, static_cast<uint>(strlen(thd->main_security_ctx.user)),