database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-30151 parse error 1=2 not between/in

Browse Source 
the parser couldn't parse `1=2 not between 3 and 5`
after `2` it expected only NOT2_SYM, but not NOT_SYM
(visible from the sql_yacc.output file), which resulted in
Syntax error ... near 'not between 3 and 4'

The parser was confused by a rather low NOT_SYM precedence and
%prec BETWEEN_SYM didn't resolve this confusion.

As a fix, let's remove any %precedence from NOT_SYM and
specify %prec explicitly in the only place where it matters for NOT_SYM.

In other places, such as for NOT BETWEEN, NOT_SYM won't have a
precedence, so bison won't be confused about it.
This commit is contained in:
Sergei Golubchik
2022-12-05 00:21:28 +01:00
parent f8adc47b69
commit eba099184e
4 changed files with 25 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
mysql-test/main/parser.result
View File

@ -1866,4 +1866,15 @@ ERROR 42000: You have an error in your SQL syntax; check the manual that corresp
EXECUTE IMMEDIATE 'CREATE PROCEDURE p() UPDATE t SET c=\'\'"abc'; EXECUTE IMMEDIATE 'CREATE PROCEDURE p() UPDATE t SET c=\'\'"abc';
ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '"abc' at line 1 ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '"abc' at line 1
SET @@sql_mode=@save_sql_mode; SET @@sql_mode=@save_sql_mode;
#
# MDEV-30151 parse error 1=2 not between/in
#
select 1=2 not in (3,4);
1=2 not in (3,4)
1
select 1=2 not between 3 and 4;
1=2 not between 3 and 4
1
#
# End of 10.3 tests # End of 10.3 tests
#

8
mysql-test/main/parser.test
View File

@ -1673,4 +1673,12 @@ EXECUTE IMMEDIATE 'CREATE PROCEDURE p() UPDATE t SET c=\'\'"abc';
SET @@sql_mode=@save_sql_mode; SET @@sql_mode=@save_sql_mode;
--echo #
--echo # MDEV-30151 parse error 1=2 not between/in
--echo #
select 1=2 not in (3,4);
select 1=2 not between 3 and 4;
--echo #
--echo # End of 10.3 tests --echo # End of 10.3 tests
--echo #

6
sql/sql_yacc.yy
View File

@ -899,7 +899,7 @@ bool my_yyoverflow(short **a, YYSTYPE **b, size_t *yystacksize);
/* /*
We should not introduce any further shift/reduce conflicts. We should not introduce any further shift/reduce conflicts.
*/ */
%expect 85 %expect 96
/* /*
Comments for TOKENS. Comments for TOKENS.
@ -1687,7 +1687,7 @@ bool my_yyoverflow(short **a, YYSTYPE **b, size_t *yystacksize);
%left PREC_BELOW_NOT %left PREC_BELOW_NOT
%nonassoc NOT_SYM %nonassoc LOW_PRIORITY_NOT
%left '=' EQUAL_SYM GE '>' LE '<' NE %left '=' EQUAL_SYM GE '>' LE '<' NE
%nonassoc IS %nonassoc IS
%right BETWEEN_SYM %right BETWEEN_SYM
@ -9840,7 +9840,7 @@ expr:
MYSQL_YYABORT; MYSQL_YYABORT;
} }
} }
| NOT_SYM expr %prec NOT_SYM | NOT_SYM expr %prec LOW_PRIORITY_NOT
{ {
$$= negate_expression(thd, $2); $$= negate_expression(thd, $2);
if (unlikely($$ == NULL)) if (unlikely($$ == NULL))

6
sql/sql_yacc_ora.yy
View File

@ -293,7 +293,7 @@ bool my_yyoverflow(short **a, YYSTYPE **b, size_t *yystacksize);
/* /*
We should not introduce any further shift/reduce conflicts. We should not introduce any further shift/reduce conflicts.
*/ */
%expect 87 %expect 98
/* /*
Comments for TOKENS. Comments for TOKENS.
@ -1081,7 +1081,7 @@ bool my_yyoverflow(short **a, YYSTYPE **b, size_t *yystacksize);
%left PREC_BELOW_NOT %left PREC_BELOW_NOT
%nonassoc NOT_SYM %nonassoc LOW_PRIORITY_NOT
%left '=' EQUAL_SYM GE '>' LE '<' NE %left '=' EQUAL_SYM GE '>' LE '<' NE
%nonassoc IS %nonassoc IS
%right BETWEEN_SYM %right BETWEEN_SYM
@ -9797,7 +9797,7 @@ expr:
MYSQL_YYABORT; MYSQL_YYABORT;
} }
} }
| NOT_SYM expr %prec NOT_SYM | NOT_SYM expr %prec LOW_PRIORITY_NOT
{ {
$$= negate_expression(thd, $2); $$= negate_expression(thd, $2);
if (unlikely($$ == NULL)) if (unlikely($$ == NULL))