database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-07 00:04:31 +03:00
Code Activity

MDEV-35078 Server crash or ASAN errors in mhnsw_insert

Browse Source 
when adding a column or index that uses plugin-defined
sysvar-based options with ALTER TABLE ... ADD, the server
was using the default value of the sysvar, not the current one.

CREATE TABLE was correctly using the current sysvar value.

Fix it so that new columns/indexes added in ALTER TABLE ... ADD
would use a current sysvar value. Existing columns/indexes
in ALTER TABLE would keep using the default sysvar value
(unless they had an explicit value in frm).
This commit is contained in:
Sergei Golubchik
2024-10-06 11:55:54 +02:00
parent 855aefb7b5
commit ea1e720391
7 changed files with 61 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sql/sql_table.h
View File

@@ -129,9 +129,9 @@ bool add_keyword_to_query(THD *thd, String *result, const LEX_CSTRING *keyword,
*/
#define C_CREATE_SELECT(X) ((X) > 0 ? (X) : 0)
#define C_ORDINARY_CREATE 0
#define C_ALTER_TABLE -1
#define C_ALTER_TABLE_FRM_ONLY -2
#define C_ASSISTED_DISCOVERY -3
#define C_ASSISTED_DISCOVERY -1
#define C_ALTER_TABLE -2
#define C_ALTER_TABLE_FRM_ONLY -3
int mysql_create_table_no_lock(THD *thd,
DDL_LOG_STATE *ddl_log_state,