From ea1a9e41a62d2d49b551a0d229c38dda87bdafcc Mon Sep 17 00:00:00 2001 From: unknown Date: Tue, 19 Sep 2006 16:48:01 +0200 Subject: [PATCH] Don't bother to remove the pid_file in mtr_kill_leftovers as it could potentially remove a the pidfile before the process is killed. The pid file will be removed later when var/ directory is recreated. --- mysql-test/lib/mtr_process.pl | 8 -------- 1 file changed, 8 deletions(-) diff --git a/mysql-test/lib/mtr_process.pl b/mysql-test/lib/mtr_process.pl index bf869ca91c4..1e982a83619 100644 --- a/mysql-test/lib/mtr_process.pl +++ b/mysql-test/lib/mtr_process.pl @@ -470,14 +470,6 @@ sub mtr_kill_leftovers () { mtr_debug("Got pid: $pid from file '$pidfile'"); - # Race, could have been removed between I tested with -f - # and the unlink() below, so I better check again with -f - - if ( ! unlink($pidfile) and -f $pidfile ) - { - mtr_error("can't remove $pidfile"); - } - if ( $::glob_cygwin_perl or kill(0, $pid) ) { mtr_debug("There is process with pid $pid -- scheduling for kill.");