database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

Fixed bug #29985.

Browse Source 
Multiple-result processing is required during the execution
of CALL statements for stored procedures, however the mysqlslap
client lacked that processing.



client/mysqlslap.c:
  Fixed bug #29985.
  1. Connection flags have been changed: the CLIENT_MULTI_STATEMENTS
  flag has been added.
  2. The run_task function has been modified to process multiple
  result sets.
mysql-test/t/mysqlslap.test:
  Added test case for bug #29985.
mysql-test/r/mysqlslap.result:
  Added test case for bug #29985.
This commit is contained in:
unknown
2007-09-17 21:39:07 +05:00
parent 9a20ca1390
commit ea04054077
3 changed files with 27 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
client/mysqlslap.c
View File

@ -140,7 +140,8 @@ static my_bool opt_compress= FALSE, tty_password= FALSE,
auto_generate_sql= FALSE; auto_generate_sql= FALSE;
const char *auto_generate_sql_type= "mixed"; const char *auto_generate_sql_type= "mixed";
static unsigned long connect_flags= CLIENT_MULTI_RESULTS; static unsigned long connect_flags= CLIENT_MULTI_RESULTS |
CLIENT_MULTI_STATEMENTS;
static int verbose, delimiter_length; static int verbose, delimiter_length;
static uint commit_rate; static uint commit_rate;
@ -1877,13 +1878,16 @@ limit_not_met:
} }
} }
if (mysql_field_count(mysql)) do
{ {
result= mysql_store_result(mysql); if (mysql_field_count(mysql))
while ((row = mysql_fetch_row(result))) {
counter++; result= mysql_store_result(mysql);
mysql_free_result(result); while ((row = mysql_fetch_row(result)))
} counter++;
mysql_free_result(result);
}
} while(mysql_next_result(mysql) == 0);
queries++; queries++;
if (commit_rate && commit_rate <= trans_counter) if (commit_rate && commit_rate <= trans_counter)

5
mysql-test/r/mysqlslap.result
View File

@ -211,3 +211,8 @@ COMMIT;
COMMIT; COMMIT;
SHOW TABLES; SHOW TABLES;
DROP SCHEMA IF EXISTS `mysqlslap`; DROP SCHEMA IF EXISTS `mysqlslap`;
#
# Bug #29985: mysqlslap -- improper handling of resultsets in SPROCs
#
DROP PROCEDURE IF EXISTS p1;
CREATE PROCEDURE p1() SELECT 1;

11
mysql-test/t/mysqlslap.test
View File

@ -40,3 +40,14 @@
--exec $MYSQL_SLAP --only-print --delimiter=";" --query="select * from t1;select * from t2" --create="CREATE TABLE t1 (id int, name varchar(64)); create table t2(foo1 varchar(32), foo2 varchar(32)); INSERT INTO t1 VALUES (1, 'This is a test'); insert into t2 values ('test', 'test2')" --engine="heap,myisam" --post-query="SHOW TABLES" --pre-query="SHOW TABLES" --number-of-queries=6 --commit=1; --exec $MYSQL_SLAP --only-print --delimiter=";" --query="select * from t1;select * from t2" --create="CREATE TABLE t1 (id int, name varchar(64)); create table t2(foo1 varchar(32), foo2 varchar(32)); INSERT INTO t1 VALUES (1, 'This is a test'); insert into t2 values ('test', 'test2')" --engine="heap,myisam" --post-query="SHOW TABLES" --pre-query="SHOW TABLES" --number-of-queries=6 --commit=1;
--exec $MYSQL_SLAP --silent --concurrency=5 --iterations=1 --number-int-cols=2 --number-char-cols=3 --auto-generate-sql --auto-generate-sql-add-autoincrement --auto-generate-sql-load-type=write --detach=2 --exec $MYSQL_SLAP --silent --concurrency=5 --iterations=1 --number-int-cols=2 --number-char-cols=3 --auto-generate-sql --auto-generate-sql-add-autoincrement --auto-generate-sql-load-type=write --detach=2
--echo #
--echo # Bug #29985: mysqlslap -- improper handling of resultsets in SPROCs
--echo #
--disable_warnings
DROP PROCEDURE IF EXISTS p1;
--enable_warnings
CREATE PROCEDURE p1() SELECT 1;
--exec $MYSQL_SLAP --create-schema=test --delimiter=";" --query="CALL p1; SELECT 1;" --silent 2>&1