database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-21058 CREATE TABLE with generated column and RLIKE results in sigabrt

Browse Source 
Regexp_processor_pcre::fix_owner() called Regexp_processor_pcre::compile(),
which could fail on the regex syntax error in the pattern and put
an error into the diagnostics area. However, the callers:
  - Item_func_regex::fix_length_and_dec()
  - Item_func_regexp_instr::fix_length_and_dec()
still returned "false" in such cases, which made the code
crash later inside Diagnostics_area::set_ok_status().

Fix:

- Change the return type of fix_onwer() from "void" to "bool"
  and return "true" whenever an error is put to the DA
  (e.g. on the syntax error in the pattern).
- Fixing fix_length_and_dec() of the mentioned Item_func_xxx
  classes to return "true" if fix_onwer() returned "true".
This commit is contained in:
Alexander Barkov
2024-04-24 16:54:00 +04:00
parent 267dd5a993
commit dc25d600ee
6 changed files with 118 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
mysql-test/suite/vcol/r/func_regexp.result Normal file
View File

@@ -0,0 +1,24 @@
#
# Start of 10.5 tests
#
#
# MDEV-21058 CREATE TABLE with generated column and RLIKE results in sigabrt
#
CREATE TABLE t1 (c0 INT AS(('' RLIKE '[')));
ERROR 42000: Regex error 'missing terminating ] for character class at offset 1'
CREATE TABLE t1 (c0 INT AS(REGEXP_INSTR('','[')));
ERROR 42000: Regex error 'missing terminating ] for character class at offset 1'
CREATE TABLE t1
(
c0 INT,
c1 INT AS(('' RLIKE NULL)),
c2 INT AS(REGEXP_INSTR('',NULL))
);
INSERT INTO t1 (c0) VALUES (0);
SELECT * FROM t1;
c0 c1 c2
0 NULL NULL
DROP TABLE t1;
#
# End of 10.5 tests
#