database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-21058 CREATE TABLE with generated column and RLIKE results in sigabrt

Browse Source 
Regexp_processor_pcre::fix_owner() called Regexp_processor_pcre::compile(),
which could fail on the regex syntax error in the pattern and put
an error into the diagnostics area. However, the callers:
  - Item_func_regex::fix_length_and_dec()
  - Item_func_regexp_instr::fix_length_and_dec()
still returned "false" in such cases, which made the code
crash later inside Diagnostics_area::set_ok_status().

Fix:

- Change the return type of fix_onwer() from "void" to "bool"
  and return "true" whenever an error is put to the DA
  (e.g. on the syntax error in the pattern).
- Fixing fix_length_and_dec() of the mentioned Item_func_xxx
  classes to return "true" if fix_onwer() returned "true".
This commit is contained in:
Alexander Barkov
2024-04-24 16:54:00 +04:00
parent 267dd5a993
commit dc25d600ee
6 changed files with 118 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
mysql-test/main/func_regexp.test
View File

@ -132,5 +132,22 @@ SELECT (c1 RLIKE c1), (c0 IS NULL) FROM t0;
SELECT SUM(a.t) FROM (SELECT (c1 RLIKE c1) = (c0 IS NULL) as t FROM t0) as a;
DROP TABLE t0;
--echo #
--echo # MDEV-21058 CREATE TABLE with generated column and RLIKE results in sigabrt
--echo #
CREATE TABLE t1 (c0 INT);
INSERT INTO t1 VALUES (1),(2),(3);
--error ER_REGEXP_ERROR
SELECT ('' RLIKE '[') AS c1 FROM t1;
--error ER_REGEXP_ERROR
SELECT REGEXP_INSTR('','[') AS c1 FROM t1;
SELECT c0, '' RLIKE NULL AS c1, REGEXP_INSTR('', NULL) AS c2
FROM t1 ORDER BY c0;
DROP TABLE t1;
--echo # End of 10.5 tests