database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-34348: Consolidate cmp function declarations

Browse Source 
Partial commit of the greater MDEV-34348 scope.
MDEV-34348: MariaDB is violating clang-16 -Wcast-function-type-strict

The functions queue_compare, qsort2_cmp, and qsort_cmp2
all had similar interfaces, and were used interchangable
and unsafely cast to one another.

This patch consolidates the functions all into the
qsort_cmp2 interface.

Reviewed By:
============
Marko Mäkelä <marko.makela@mariadb.com>
This commit is contained in:
Brandon Nesterenko
2024-10-26 08:17:03 -06:00
parent 3997d28f48
commit dbfee9fc2b
83 changed files with 678 additions and 524 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sql/rpl_gtid.cc
View File

@@ -2925,10 +2925,10 @@ gtid_waiting::destroy()
static int
cmp_queue_elem(void *, uchar *a, uchar *b)
cmp_queue_elem(void *, const void *a, const void *b)
{
uint64 seq_no_a= *(uint64 *)a;
uint64 seq_no_b= *(uint64 *)b;
auto seq_no_a= *(static_cast<const uint64 *>(a));
auto seq_no_b= *(static_cast<const uint64 *>(b));
if (seq_no_a < seq_no_b)
return -1;
else if (seq_no_a == seq_no_b)