database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-05 13:16:09 +03:00
Code Activity

MDEV-34348: Consolidate cmp function declarations

Browse Source 
Partial commit of the greater MDEV-34348 scope.
MDEV-34348: MariaDB is violating clang-16 -Wcast-function-type-strict

The functions queue_compare, qsort2_cmp, and qsort_cmp2
all had similar interfaces, and were used interchangable
and unsafely cast to one another.

This patch consolidates the functions all into the
qsort_cmp2 interface.

Reviewed By:
============
Marko Mäkelä <marko.makela@mariadb.com>
This commit is contained in:
Brandon Nesterenko
2024-10-26 08:17:03 -06:00
parent 3997d28f48
commit dbfee9fc2b
83 changed files with 678 additions and 524 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
mysys/thr_timer.c
View File

@@ -46,10 +46,11 @@ static void *timer_handler(void *arg __attribute__((unused)));
*/
static int compare_timespec(void *not_used __attribute__((unused)),
uchar *a_ptr, uchar *b_ptr)
const void *a_ptr, const void *b_ptr)
{
return cmp_timespec((*(struct timespec*) a_ptr),
(*(struct timespec*) b_ptr));
const struct timespec *ap= a_ptr;
const struct timespec *bp= b_ptr;
return cmp_timespec((*ap), (*bp));
}