mirror of
https://github.com/MariaDB/server.git
synced 2025-08-07 00:04:31 +03:00
MDEV-7947 strcmp() takes 0.37% in OLTP RO
This patch ensures that all identical character sets shares the same cs->csname. This allows us to replace strcmp() in my_charset_same() with comparisons of pointers. This fixes a long standing performance issue that could cause as strcmp() for every item sent trough the protocol class to the end user. One consequence of this patch is that we don't allow one to add a character definition in the Index.xml file that changes the csname of an existing character set. This is by design as changing character set names of existing ones is extremely dangerous, especially as some storage engines just records character set numbers. As we now have a hash over character set's csname, we can in the future use that for faster access to a specific character set. This could be done by changing the hash to non unique and use the hash to find the next character set with same csname.
This commit is contained in:
@@ -36,6 +36,12 @@
|
||||
|
||||
*/
|
||||
|
||||
const char charset_name_latin2[]= "latin2";
|
||||
const char charset_name_utf8[]= "utf8";
|
||||
const char charset_name_utf16[]= "utf16";
|
||||
const char charset_name_utf32[]= "utf32";
|
||||
const char charset_name_ucs2[]= "ucs2";
|
||||
const char charset_name_utf8mb4[]= "utf8mb4";
|
||||
|
||||
/*
|
||||
Avoid using my_snprintf
|
||||
|
Reference in New Issue
Block a user