database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-33746 Supply missing override markings

Browse Source 
Find and fix missing virtual override markings.  Updates cmake
maintainer flags to include -Wsuggest-override and
-Winconsistent-missing-override.
This commit is contained in:
Dave Gosselin
2024-06-12 09:46:26 -04:00
committed by Dave Gosselin
parent ab448d4b34
commit db0c28eff8
306 changed files with 8808 additions and 8781 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
storage/perfschema/pfs_variable.h
View File

@@ -205,7 +205,7 @@ public:
Find_THD_variable() : m_unsafe_thd(NULL) {}
Find_THD_variable(THD *unsafe_thd) : m_unsafe_thd(unsafe_thd) {}
virtual bool operator()(THD *thd)
bool operator()(THD *thd) override
{
//TODO: filter bg threads?
if (thd != m_unsafe_thd)
@@ -608,18 +608,18 @@ public:
private:
/* Build SHOW_var array. */
bool init_show_var_array(enum_var_type scope, bool strict);
bool do_initialize_session(void);
bool do_initialize_session(void) override;
/* Global */
int do_materialize_global(void);
int do_materialize_global(void) override;
/* Global and Session - THD */
int do_materialize_all(THD* thd);
int do_materialize_all(THD* thd) override;
/* Session - THD */
int do_materialize_session(THD* thd);
int do_materialize_session(THD* thd) override;
/* Session - PFS_thread */
int do_materialize_session(PFS_thread *thread);
int do_materialize_session(PFS_thread *thread) override;
/* Single variable - PFS_thread */
int do_materialize_session(PFS_thread *pfs_thread, uint index);
int do_materialize_session(PFS_thread *pfs_thread, uint index) override;
/* Temporary mem_root to use for materialization. */
MEM_ROOT m_mem_sysvar;
@@ -660,14 +660,14 @@ protected:
bool m_show_command;
private:
bool do_initialize_session(void);
bool do_initialize_session(void) override;
int do_materialize_global(void);
int do_materialize_global(void) override;
/* Global and Session - THD */
int do_materialize_all(THD* thd);
int do_materialize_session(THD *thd);
int do_materialize_session(PFS_thread *thread);
int do_materialize_session(PFS_thread *thread, uint index) { return 0; }
int do_materialize_all(THD* thd) override;
int do_materialize_session(THD *thd) override;
int do_materialize_session(PFS_thread *thread) override;
int do_materialize_session(PFS_thread *thread, uint index) override { return 0; }
int do_materialize_client(PFS_client *pfs_client);
/* Callback to sum user, host or account status variables. */