database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-30 16:24:05 +03:00
Code Activity

MDEV-33746 Supply missing override markings

Browse Source 
Find and fix missing virtual override markings.  Updates cmake
maintainer flags to include -Wsuggest-override and
-Winconsistent-missing-override.
This commit is contained in:
Dave Gosselin
2024-06-12 09:46:26 -04:00
committed by Dave Gosselin
parent ab448d4b34
commit db0c28eff8
306 changed files with 8808 additions and 8781 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
sql/wsrep_high_priority_service.h
View File

@ -33,31 +33,31 @@ public:
Wsrep_high_priority_service(THD*);
~Wsrep_high_priority_service();
int start_transaction(const wsrep::ws_handle&,
const wsrep::ws_meta&);
int next_fragment(const wsrep::ws_meta&);
const wsrep::transaction& transaction() const;
int adopt_transaction(const wsrep::transaction&);
const wsrep::ws_meta&) override;
int next_fragment(const wsrep::ws_meta&) override;
const wsrep::transaction& transaction() const override;
int adopt_transaction(const wsrep::transaction&) override;
int apply_write_set(const wsrep::ws_meta&, const wsrep::const_buffer&,
wsrep::mutable_buffer&) = 0;
wsrep::mutable_buffer&) override = 0;
int append_fragment_and_commit(const wsrep::ws_handle&,
const wsrep::ws_meta&,
const wsrep::const_buffer&,
const wsrep::xid&);
int remove_fragments(const wsrep::ws_meta&);
int commit(const wsrep::ws_handle&, const wsrep::ws_meta&);
int rollback(const wsrep::ws_handle&, const wsrep::ws_meta&);
const wsrep::xid&) override;
int remove_fragments(const wsrep::ws_meta&) override;
int commit(const wsrep::ws_handle&, const wsrep::ws_meta&) override;
int rollback(const wsrep::ws_handle&, const wsrep::ws_meta&) override;
int apply_toi(const wsrep::ws_meta&, const wsrep::const_buffer&,
wsrep::mutable_buffer&);
void store_globals();
void reset_globals();
void switch_execution_context(wsrep::high_priority_service&);
wsrep::mutable_buffer&) override;
void store_globals() override;
void reset_globals() override;
void switch_execution_context(wsrep::high_priority_service&) override;
int log_dummy_write_set(const wsrep::ws_handle&,
const wsrep::ws_meta&,
wsrep::mutable_buffer&);
void adopt_apply_error(wsrep::mutable_buffer&);
wsrep::mutable_buffer&) override;
void adopt_apply_error(wsrep::mutable_buffer&) override;
virtual bool check_exit_status() const = 0;
void debug_crash(const char*);
void debug_crash(const char*) override;
protected:
friend Wsrep_server_service;
THD* m_thd;
@ -84,12 +84,12 @@ public:
Wsrep_applier_service(THD*);
~Wsrep_applier_service();
int apply_write_set(const wsrep::ws_meta&, const wsrep::const_buffer&,
wsrep::mutable_buffer&);
wsrep::mutable_buffer&) override;
int apply_nbo_begin(const wsrep::ws_meta&, const wsrep::const_buffer& data,
wsrep::mutable_buffer& err);
void after_apply();
bool is_replaying() const { return false; }
bool check_exit_status() const;
wsrep::mutable_buffer& err) override;
void after_apply() override;
bool is_replaying() const override { return false; }
bool check_exit_status() const override;
};
class Wsrep_replayer_service : public Wsrep_high_priority_service
@ -98,21 +98,21 @@ public:
Wsrep_replayer_service(THD* replayer_thd, THD* orig_thd);
~Wsrep_replayer_service();
int apply_write_set(const wsrep::ws_meta&, const wsrep::const_buffer&,
wsrep::mutable_buffer&);
wsrep::mutable_buffer&) override;
int apply_nbo_begin(const wsrep::ws_meta&, const wsrep::const_buffer& data,
wsrep::mutable_buffer& err)
wsrep::mutable_buffer& err) override
{
DBUG_ASSERT(0); /* DDL should never cause replaying */
return 0;
}
void after_apply() { }
bool is_replaying() const { return true; }
void after_apply() override { }
bool is_replaying() const override { return true; }
void replay_status(enum wsrep::provider::status status)
{ m_replay_status = status; }
enum wsrep::provider::status replay_status() const
{ return m_replay_status; }
/* Replayer should never be forced to exit */
bool check_exit_status() const { return false; }
bool check_exit_status() const override { return false; }
private:
THD* m_orig_thd;
struct da_shadow