1
0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00

MDEV-33746 Supply missing override markings

Find and fix missing virtual override markings.  Updates cmake
maintainer flags to include -Wsuggest-override and
-Winconsistent-missing-override.
This commit is contained in:
Dave Gosselin
2024-06-12 09:46:26 -04:00
committed by Dave Gosselin
parent ab448d4b34
commit db0c28eff8
306 changed files with 8808 additions and 8781 deletions

View File

@ -1061,7 +1061,7 @@ public:
bool handle_condition(THD *thd, uint sql_errno, const char * /* sqlstate */,
Sql_condition::enum_warning_level *level,
const char *message, Sql_condition ** /* cond_hdl */)
const char *message, Sql_condition ** /* cond_hdl */) override
{
/*
The handler does not handle the errors raised by itself.
@ -5101,7 +5101,7 @@ class Warnings_only_error_handler : public Internal_error_handler
public:
bool handle_condition(THD *thd, uint sql_errno, const char* sqlstate,
Sql_condition::enum_warning_level *level,
const char* msg, Sql_condition ** cond_hdl)
const char* msg, Sql_condition ** cond_hdl) override
{
if (sql_errno == ER_TRG_NO_DEFINER || sql_errno == ER_TRG_NO_CREATION_CTX
|| sql_errno == ER_PARSE_ERROR)
@ -10304,12 +10304,12 @@ class IS_internal_schema_access : public ACL_internal_schema_access
public:
IS_internal_schema_access() = default;
~IS_internal_schema_access() = default;
~IS_internal_schema_access() override = default;
ACL_internal_access_result check(privilege_t want_access,
privilege_t *save_priv) const;
privilege_t *save_priv) const override;
const ACL_internal_table_access *lookup(const char *name) const;
const ACL_internal_table_access *lookup(const char *name) const override;
};
ACL_internal_access_result