database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-33746 Supply missing override markings

Browse Source 
Find and fix missing virtual override markings.  Updates cmake
maintainer flags to include -Wsuggest-override and
-Winconsistent-missing-override.
This commit is contained in:
Dave Gosselin
2024-06-12 09:46:26 -04:00
committed by Dave Gosselin
parent ab448d4b34
commit db0c28eff8
306 changed files with 8808 additions and 8781 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
sql/sql_plugin.cc
View File

@ -314,22 +314,22 @@ public:
sys_var_pluginvar(sys_var_chain *chain, const char *name_arg,
st_plugin_int *p, st_mysql_sys_var *plugin_var_arg,
const char *substitute);
sys_var_pluginvar *cast_pluginvar() { return this; }
sys_var_pluginvar *cast_pluginvar() override { return this; }
uchar* real_value_ptr(THD *thd, enum_var_type type) const;
TYPELIB* plugin_var_typelib(void) const;
const uchar* do_value_ptr(THD *thd, enum_var_type type, const LEX_CSTRING *base) const;
const uchar* session_value_ptr(THD *thd, const LEX_CSTRING *base) const
const uchar* session_value_ptr(THD *thd, const LEX_CSTRING *base) const override
{ return do_value_ptr(thd, OPT_SESSION, base); }
const uchar* global_value_ptr(THD *thd, const LEX_CSTRING *base) const
const uchar* global_value_ptr(THD *thd, const LEX_CSTRING *base) const override
{ return do_value_ptr(thd, OPT_GLOBAL, base); }
const uchar *default_value_ptr(THD *thd) const
const uchar *default_value_ptr(THD *thd) const override
{ return do_value_ptr(thd, OPT_DEFAULT, 0); }
bool do_check(THD *thd, set_var *var);
virtual void session_save_default(THD *thd, set_var *var) {}
virtual void global_save_default(THD *thd, set_var *var) {}
bool session_update(THD *thd, set_var *var);
bool global_update(THD *thd, set_var *var);
bool session_is_default(THD *thd);
bool do_check(THD *thd, set_var *var) override;
void session_save_default(THD *thd, set_var *var) override {}
void global_save_default(THD *thd, set_var *var) override {}
bool session_update(THD *thd, set_var *var) override;
bool global_update(THD *thd, set_var *var) override;
bool session_is_default(THD *thd) override;
};