database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-07-29 05:21:33 +03:00
Code Activity

MDEV-33746 Supply missing override markings

Browse Source 
Find and fix missing virtual override markings.  Updates cmake
maintainer flags to include -Wsuggest-override and
-Winconsistent-missing-override.
This commit is contained in:
Dave Gosselin
2024-06-12 09:46:26 -04:00
committed by Dave Gosselin
parent ab448d4b34
commit db0c28eff8
306 changed files with 8808 additions and 8781 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
sql/sql_insert.cc
View File

@ -2298,7 +2298,7 @@ public:
forced_insert_id(0), query(query_arg), time_zone(0),
user(0), host(0), ip(0)
{}
~delayed_row()
~delayed_row() override
{
my_free(query.str);
my_free(record);
@ -2381,7 +2381,7 @@ public:
TL_WRITE_LOW_PRIORITY : TL_WRITE;
DBUG_VOID_RETURN;
}
~Delayed_insert()
~Delayed_insert() override
{
/* The following is not really needed, but just for safety */
delayed_row *row;
@ -3057,13 +3057,13 @@ void kill_delayed_threads(void)
class Delayed_prelocking_strategy : public Prelocking_strategy
{
public:
virtual bool handle_routine(THD *thd, Query_tables_list *prelocking_ctx,
bool handle_routine(THD *thd, Query_tables_list *prelocking_ctx,
Sroutine_hash_entry *rt, sp_head *sp,
bool *need_prelocking);
virtual bool handle_table(THD *thd, Query_tables_list *prelocking_ctx,
TABLE_LIST *table_list, bool *need_prelocking);
virtual bool handle_view(THD *thd, Query_tables_list *prelocking_ctx,
TABLE_LIST *table_list, bool *need_prelocking);
bool *need_prelocking) override;
bool handle_table(THD *thd, Query_tables_list *prelocking_ctx,
TABLE_LIST *table_list, bool *need_prelocking) override;
bool handle_view(THD *thd, Query_tables_list *prelocking_ctx,
TABLE_LIST *table_list, bool *need_prelocking) override;
};
@ -4729,7 +4729,7 @@ select_create::prepare(List<Item> &_values, SELECT_LEX_UNIT *u)
}
private:
virtual int do_postlock(TABLE **tables, uint count)
int do_postlock(TABLE **tables, uint count) override
{
int error;
THD *thd= const_cast<THD*>(ptr->get_thd());