database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-08 11:22:35 +03:00
Code Activity

MDEV-33746 Supply missing override markings

Browse Source 
Find and fix missing virtual override markings.  Updates cmake
maintainer flags to include -Wsuggest-override and
-Winconsistent-missing-override.
This commit is contained in:
Dave Gosselin
2024-06-12 09:46:26 -04:00
committed by Dave Gosselin
parent ab448d4b34
commit db0c28eff8
306 changed files with 8808 additions and 8781 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
sql/opt_table_elimination.cc
View File

@@ -251,9 +251,9 @@ public:
Field *field; /* Field this object is representing */
/* Iteration over unbound modules that are our dependencies */
Iterator init_unbound_modules_iter(char *buf);
Iterator init_unbound_modules_iter(char *buf) override;
Dep_module* get_next_unbound_module(Dep_analysis_context *dac,
Iterator iter);
Iterator iter) override;
void make_unbound_modules_iter_skip_keys(Iterator iter);
@@ -310,9 +310,9 @@ public:
Dep_module_key *keys; /* Ordered list of Unique keys in this table */
/* Iteration over unbound modules that are our dependencies */
Iterator init_unbound_modules_iter(char *buf);
Iterator init_unbound_modules_iter(char *buf) override;
Dep_module* get_next_unbound_module(Dep_analysis_context *dac,
Iterator iter);
Iterator iter) override;
static const size_t iterator_size;
private:
class Module_iter
@@ -394,8 +394,8 @@ public:
/* Used during condition analysis only, similar to KEYUSE::level */
uint level;
Iterator init_unbound_values_iter(char *buf);
Dep_value* get_next_unbound_value(Dep_analysis_context *dac, Iterator iter);
Iterator init_unbound_values_iter(char *buf) override;
Dep_value* get_next_unbound_value(Dep_analysis_context *dac, Iterator iter) override;
static const size_t iterator_size;
private:
class Value_iter
@@ -429,8 +429,8 @@ public:
/* Unique keys form a linked list, ordered by keyno */
Dep_module_key *next_table_key;
Iterator init_unbound_values_iter(char *buf);
Dep_value* get_next_unbound_value(Dep_analysis_context *dac, Iterator iter);
Iterator init_unbound_values_iter(char *buf) override;
Dep_value* get_next_unbound_value(Dep_analysis_context *dac, Iterator iter) override;
static const size_t iterator_size;
private:
class Value_iter
@@ -459,18 +459,18 @@ public:
{
unbound_args= n_children;
}
bool is_final() { return TRUE; }
bool is_final() override { return TRUE; }
/*
This is the goal module, so the running wave algorithm should terminate
once it sees that this module is applicable and should never try to apply
it, hence no use for unbound value iterator implementation.
*/
Iterator init_unbound_values_iter(char *buf)
Iterator init_unbound_values_iter(char *buf) override
{
DBUG_ASSERT(0);
return NULL;
}
Dep_value* get_next_unbound_value(Dep_analysis_context *dac, Iterator iter)
Dep_value* get_next_unbound_value(Dep_analysis_context *dac, Iterator iter) override
{
DBUG_ASSERT(0);
return NULL;
@@ -966,7 +966,7 @@ public:
Field_dependency_recorder(Dep_analysis_context *ctx_arg): ctx(ctx_arg)
{}
void visit_field(Item_field *item)
void visit_field(Item_field *item) override
{
Field *field= item->field;
Dep_value_table *tbl_dep;